Repository navigation
fix(logs): keep checked trace content at every depth when the projection budget runs out - #9697
waleedlatif1 wants to merge 1 commit into
Conversation
…ion budget runs out Also tidy what the release review found in the same range: shared UTF-8 length helper, redundant mounted guards, session-expired wrapper, misplaced TSDoc, repeated capture copy, and a styled page-access error.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The changes reach trace viewing and several browser-extension screens. The PR appears safe to merge, with a non-blocking timing issue in the voice test. Findings
SummaryKeeps checked trace content at every depth when the content budget runs out.
No runtime tests were run during this review.
|
| await mic.click() | ||
| await expect(stop).toBeVisible() | ||
| await expect.poll(() => sessions.length).toBe(2) | ||
| assert.equal(sessions[0].closed, false, 'Stale-transcript grace must still be open') |
There was a problem hiding this comment.
If restarting voice input takes more than two seconds, this assertion fails even when voice input works correctly. stopStreaming closes the old socket after two seconds, but the test waits for several browser actions and a new connection before checking sessions[0].closed.
Pause the browser clock during the restart, then advance it after sending the stale transcript. This would test the guard without making CI speed part of the result.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
workflow-executionroot, so retention that only worked per top-level span withheld everything. This changes the rule pinned by the old "withholds the whole top-level span" test. Each retained span's own content still passes the whole-trace check before its children are walked, and any failure other than the budget still withholds the whole traceretainedSpanCount: 0utf8ByteLengthinstead of a throwaway encode, redundant mounted guards in the speech hook and page-access button,ExtensionSessionExpiredat its three call sites, shared capture copy, a styled page-access error, and a guard that the stale-transcript e2e sends before the socket closesType of Change
Testing
trace-secret-projectionregression test fails on the previous code and passes now, with a rooted fixture and a non-budget failure caselib/logs/execution,lib/sim-linksandprocess-contentsVitest: 451 passing; extension type-check; biome. Full audits and e2e run in CIChecklist
test-auditauthoring gate)