feat(socket-mode): support undici v8 as a peer dependency by WilliamBergamin · Pull Request #2694 · slackapi/node-slack-sdk

WilliamBergamin · 2026-08-10T18:37:50Z

Summary

Expand @slack/socket-mode to support both undici@^7 and undici@^8 as a peer dependency.

Widen peerDependencies.undici to ^7.0.0 || ^8.0.0. The source needs no logic changes
CI now pairs each Node version with an undici major via a versions: [{ node, undici }] matrix and forces the socket-mode workspace onto that major before running the suite.

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

Widen the `undici` peer dependency range to `^7.0.0 || ^8.0.0` so consumers can bring either major. undici v8 requires Node >=22.19, while v7 continues to support Node >=20 — the source needs no changes, as v8 preserves every API socket-mode uses. CI now pairs each Node version with an undici major via a `versions` matrix and forces the socket-mode workspace onto that major before running the suite, so v8 support is actually exercised on capable Node versions. A new guardrail test asserts the Node/undici pairing (and never allows v8 on Node <22.19). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

changeset-bot · 2026-08-10T18:37:54Z

🦋 Changeset detected

Latest commit: 7e1e685

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@slack/socket-mode	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

codecov · 2026-08-10T18:41:25Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.20%. Comparing base (d420d00) to head (7e1e685).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
+ Coverage   89.12%   89.20%   +0.07%     
==========================================
  Files          65       65              
  Lines       10441    10442       +1     
  Branches      482      480       -2     
==========================================
+ Hits         9306     9315       +9     
+ Misses       1103     1095       -8     
  Partials       32       32

Flag	Coverage Δ
cli-hooks	`89.12% <0.00%> (-0.01%)`	⬇️
cli-test	`89.12% <0.00%> (-0.01%)`	⬇️
logger	`89.12% <0.00%> (-0.01%)`	⬇️
oauth	`89.12% <0.00%> (-0.01%)`	⬇️
socket-mode	`89.12% <0.00%> (-0.01%)`	⬇️
web-api	`89.12% <0.00%> (-0.01%)`	⬇️
webhook	`89.12% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Reduce the undici peer-dependency test to its two assertions, drop the comment essays and the general-purpose version-comparison helper in favor of a plain Node major check, and rename SOCKET_MODE_EXPECT_UNDICI_MAJOR to SOCKET_MODE_UNDICI_VERSION. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

WilliamBergamin · 2026-08-19T17:17:01Z

@zimeg I'll need to update the status checks if we want to merge this

zimeg

@WilliamBergamin LGTM! I'm bummed CI wasn't calling this out with regular installations but this is a good fix to include.

🧪 Longterm I'm worried about testing compatible dependencies with unit tests but let's get this merged to address an issue!

zimeg · 2026-08-31T17:42:05Z

  },
  "peerDependencies": {
-    "undici": "^7.0.0"
+    "undici": "^7.0.0 || ^8.0.0"


🎯 praise: Thanks for keeping support consistent!

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

… job undici v8 flips buildConnector's allowH2 default to true, so the default dispatcher offered h2 over ALPN. Pin allowH2: false so the WebSocket stays on HTTP/1.1 (where the force-destroy fallback holds) on both majors. A test parses the ALPN list from the raw ClientHello (no certificate needed) and asserts the client only offers http/1.1; it fails on v8 without the fix. CI: restore the original matrix (undici v7 on every Node) and add a socket-mode-undici-v8 job on Node 22/24/26. Drop the guardrail unit test, whose inverted assertion failed every job; the job checks the installed major inline instead. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Replaces the separate socket-mode-undici-v8 job. The steps run on every Node except 20.x (undici v8 needs >=22.19), on both ubuntu and windows, after the codecov uploads so socket-mode's v7 test results aren't overwritten. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Add an undici dimension (excluding Node 20 + v8, since v8 needs >=22.19) in place of the extra steps. Job names gain the undici version, so the required status checks on main need updating to match. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Slack's WebSocket hosts negotiate HTTP/1.1 today, so the allowH2: false pin stays as cheap insurance without a dedicated test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

WilliamBergamin and others added 2 commits August 10, 2026 14:38

docs(ci): condense undici install step comment to one line

7edc776

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

docs(ci): trim undici install step comment

4cabd4a

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

WilliamBergamin self-assigned this Aug 10, 2026

WilliamBergamin added tests M-T: Testing work only dependencies Pull requests that update a dependency file labels Aug 10, 2026

WilliamBergamin requested a review from zimeg August 10, 2026 18:58

WilliamBergamin marked this pull request as ready for review August 10, 2026 18:58

WilliamBergamin requested a review from a team as a code owner August 10, 2026 18:58

WilliamBergamin added this to the socket-mode@next milestone Aug 10, 2026

WilliamBergamin and others added 3 commits August 10, 2026 15:14

Merge branch 'main' into expand-undici-support

7473bef

Merge branch 'main' into expand-undici-support

42ac8ba

WilliamBergamin added 2 commits August 27, 2026 10:06

Merge branch 'main' into expand-undici-support

f1decb9

Merge branch 'main' into expand-undici-support

7471105

zimeg approved these changes Aug 31, 2026

View reviewed changes

zimeg mentioned this pull request Aug 31, 2026

feat: declare undici as a peer dependency for Socket Mode slackapi/bolt-js#3040

Open

2 tasks

WilliamBergamin and others added 2 commits August 31, 2026 11:33

Apply suggestion from @zimeg

c0746b2

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

Merge branch 'main' into expand-undici-support

623f759

WilliamBergamin mentioned this pull request Sep 10, 2026

chore(deps-dev): bump undici from 7.29.0 to 8.10.2 #2740

Closed

WilliamBergamin and others added 2 commits September 24, 2026 11:33

Merge branch 'main' into expand-undici-support

e8462c6

WilliamBergamin force-pushed the expand-undici-support branch from a9623e1 to bb11653 Compare September 24, 2026 16:18

WilliamBergamin and others added 4 commits September 24, 2026 12:19

ci: install the matrix's undici major on every job

3ebf000

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

ci: name the undici matrix entries by their install spec

acb1c81

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

WilliamBergamin and others added 2 commits September 24, 2026 12:41

test(socket-mode): drop the ALPN integration test

5108e95

Slack's WebSocket hosts negotiate HTTP/1.1 today, so the allowH2: false pin stays as cheap insurance without a dedicated test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

docs(socket-mode): trim the allowH2 comments

7e1e685

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

WilliamBergamin merged commit 334e6a6 into main Sep 24, 2026
17 of 18 checks passed

WilliamBergamin deleted the expand-undici-support branch September 24, 2026 16:54

Navigation Menu

feat(socket-mode): support undici v8 as a peer dependency - #2694

feat(socket-mode): support undici v8 as a peer dependency#2694
WilliamBergamin merged 18 commits into
mainfrom
expand-undici-support

WilliamBergamin commented Aug 10, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

WilliamBergamin commented Aug 19, 2026

Uh oh!

zimeg left a comment

Uh oh!

Uh oh!

zimeg Aug 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

WilliamBergamin commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Requirements

Uh oh!

changeset-bot Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

WilliamBergamin commented Aug 19, 2026

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zimeg Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WilliamBergamin commented Aug 10, 2026 •

edited

Loading

changeset-bot Bot commented Aug 10, 2026 •

edited

Loading

codecov Bot commented Aug 10, 2026 •

edited

Loading