-
Notifications
You must be signed in to change notification settings - Fork 686
feat(socket-mode): support undici v8 as a peer dependency #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+18
−2
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cd68c2b
feat(socket-mode): support undici v8 as a peer dependency
WilliamBergamin 7edc776
docs(ci): condense undici install step comment to one line
WilliamBergamin 4cabd4a
docs(ci): trim undici install step comment
WilliamBergamin 3e6270d
test(socket-mode): simplify undici version guardrail test
WilliamBergamin 7473bef
Merge branch 'main' into expand-undici-support
WilliamBergamin 42ac8ba
Merge branch 'main' into expand-undici-support
WilliamBergamin f1decb9
Merge branch 'main' into expand-undici-support
WilliamBergamin 7471105
Merge branch 'main' into expand-undici-support
WilliamBergamin c0746b2
Apply suggestion from @zimeg
WilliamBergamin 623f759
Merge branch 'main' into expand-undici-support
WilliamBergamin e8462c6
Merge branch 'main' into expand-undici-support
WilliamBergamin bb11653
fix(socket-mode): pin HTTP/1.1 on undici v8 and test v8 in its own CI…
WilliamBergamin 4d3c1d2
ci: run socket-mode's undici v8 tests as steps in the existing test job
WilliamBergamin d4e6378
ci: test undici v7 and v8 through the existing matrix
WilliamBergamin 3ebf000
ci: install the matrix's undici major on every job
WilliamBergamin acb1c81
ci: name the undici matrix entries by their install spec
WilliamBergamin 5108e95
test(socket-mode): drop the ALPN integration test
WilliamBergamin 7e1e685
docs(socket-mode): trim the allowH2 comments
WilliamBergamin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@slack/socket-mode": minor | ||
| --- | ||
|
|
||
| Support `undici@^8` as a peer dependency in addition to `undici@^7`. `undici@^8` requires Node.js >=22.19; `undici@^7` continues to support Node.js >=20. | ||
|
|
||
| The default dispatcher now pins the WebSocket connection to HTTP/1.1, since `undici@^8` offers HTTP/2 by default. To do the same with a custom `ProxyAgent` dispatcher, pass `requestTls: { allowH2: false }`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 praise: Thanks for keeping support consistent!