add Stellar support for mcms adapters, RPC providers, chain config, and blockchain#714
add Stellar support for mcms adapters, RPC providers, chain config, and blockchain#714FelixFan1992 merged 20 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 83cd735 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR adds a simple RPC provider implementation for the Stellar blockchain network within the chainlink-deployments-framework. It introduces the foundational types and structures needed to support Stellar chain operations.
Changes:
- Introduces
ChainandChainMetadatatypes for Stellar network representation - Implements
RPCChainProviderwith configuration and initialization logic - Adds validation for required Stellar network parameters (NetworkPassphrase, FriendbotURL, SorobanRPCURL)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| chain/stellar/stellar_chain.go | Defines the basic Chain struct and ChainMetadata type alias for Stellar networks |
| chain/stellar/provider/rpc_provider.go | Implements RPCChainProvider with configuration validation and chain initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
you're missing an addition to the mcms adapters here
e4a6b9a to
45fb332
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
878cafd to
955678f
Compare
added |
gustavogama-cll
left a comment
There was a problem hiding this comment.
Looks good to me but I'm still new. If you can, wait for a CLD engineer's approval before merging.
graham-chainlink
left a comment
There was a problem hiding this comment.
well done, i got a few comments to address
Update the README to include instructions for updating the MCMS adapter when adding a new chain to the framework. This step was previously missing and was highlighted in PR #714 during the Stellar chain integration. The new section documents: - How to update chain/mcms/adapters/chain_access.go with the new chain's client accessor method - How to add the chain getter to the ChainsFetcher interface - How to update the corresponding test file with test coverage This ensures developers remember to update MCMS-related code when adding new chains that support MCMS operations.
Update the README to include instructions for updating the MCMS adapter when adding a new chain to the framework. This step was previously missing and was highlighted in PR #714 during the Stellar chain integration. The new section documents: - How to update chain/mcms/adapters/chain_access.go with the new chain's client accessor method - How to add the chain getter to the ChainsFetcher interface - How to update the corresponding test file with test coverage This ensures developers remember to update MCMS-related code when adding new chains that support MCMS operations.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.80.1 ### Patch Changes - [#719](#719) [`f4aad62`](f4aad62) Thanks [@ajaskolski](https://github.com/ajaskolski)! - refactor(modular-cmds): create addressbook modular command and delegate legacy one to it - [#730](#730) [`c6b6eae`](c6b6eae) Thanks [@krebernisak](https://github.com/krebernisak)! - Bump github.com/smartcontractkit/chainlink-ton@83535910e2c0 and use bounded trace to confirm tx - [#728](#728) [`3a7f8d0`](3a7f8d0) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump CTF to v0.14.0 - [#716](#716) [`8c0cc40`](8c0cc40) Thanks [@bytesizedroll](https://github.com/bytesizedroll)! - Migration reference fix - [#714](#714) [`c4522c1`](c4522c1) Thanks [@FelixFan1992](https://github.com/FelixFan1992)! - add Stellar support for mcms adapters, RPC provider, chain config, and blockchain - [#723](#723) [`9e501d5`](9e501d5) Thanks [@RodrigoAD](https://github.com/RodrigoAD)! - Fix sui timelock decoder - [#725](#725) [`8ce7726`](8ce7726) Thanks [@FelixFan1992](https://github.com/FelixFan1992)! - add a ctf provider for Stellar - [#729](#729) [`901ba0b`](901ba0b) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump chain-selectors to v1.0.96 - [#720](#720) [`b296b7d`](b296b7d) Thanks [@krebernisak](https://github.com/krebernisak)! - Revert chainlink-ccip/chains/solana to 85accaf3d28d (availabel contract release) - [#733](#733) [`9fcb21e`](9fcb21e) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump mcms to v0.36.0 --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>




No description provided.