Radmeth optimizations for continuous values - #302
Merged
Conversation
… functions via Chebyschev polynomial approximation for the gradient calculations. Number of coeffs to use is still to be determined.
…parated from the Regression classes
…onNano class for radmeth-nano
…n a separate file for optimizing paramters of the model for nano with fractional observations
…red by radmeth and radmeth-nano
…te optimization, with the newer code moved to the new file radmeth_optimize_nano.hcpp for fractional
… and almost identical to regular radmeth.cpp
…lt model has absent samples removed
…the alt model has absent samples removed
…ull order for now
…ent optimization choice for experiments
…s and templating the counts for integer vs. fractional and putting all the cache structures into one class
…ass instead of RegressionNano which was removed
…n from experiments
…s more similar and improving output messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes several options for optimization, including using the digamma and continuous values, which is slower but more accurate. For counts, the optmized series method is still present. Currently the nano uses the continuous, and the regular radmeth uses the series, but future optimizations should allow for both digamma and series for the counts when the digamma will be faster (it seems as accurate currently)