Repository navigation
ui: themed confirm/alert dialogs in place of the native ones - #278
Open
jseifeddine wants to merge 1 commit into
Open
jseifeddine wants to merge 1 commit into
jseifeddine wants to merge 1 commit into
Conversation
jseifeddine
force-pushed
the
feat/themed-dialogs
branch
from
October 12, 2026 04:21
2cb4b76 to
d702ac2
Compare
static/ui.js provides promise-based rgConfirm/rgAlert that show a themed modal matching the app, injected self-contained so it works on any page including the standalone client. Every native alert()/confirm() is replaced: delete user and revoke token (admin), revoke token (tokens), delete recording (recordings), popup-blocked (client), and terminate session, delete entry, delete folder and the SSH host-key probe (connections). Destructive actions get a red confirm button, the host-key trust prompt an accent one. From an independent review of the module: rgConfirm/rgAlert resolve any already-open dialog before replacing it, so a second call can't leave the first promise hanging; Enter acts on the focused button (Cancel cancels), and Tab is trapped between the two buttons. Part of sol1#254 tests: themed confirm/alert dialogs replace the native ones
jseifeddine
force-pushed
the
feat/themed-dialogs
branch
from
October 13, 2026 07:05
d702ac2 to
58b1e2e
Compare
jseifeddine
marked this pull request as ready for review
October 13, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on current
mainon its own: one commit, nothing from any other open PR.Fixes #260.
static/ui.js: promise-basedrgConfirm/rgAlert; every nativealert()/confirm()replaced on admin, tokens, recordings, client and connections; red confirm for destructive actions; Enter acts on the focused button, Tab trapped, a second call resolves the first.Testing
themed-dialogs.spec.mjs(fails if any native dialog is raised).