Normalize lazy-ref src values - #7
Open
Mersho wants to merge 2 commits into
Open
Conversation
On Windows OS, node:path relative() returns backslashed src values in serialized lazy refs. Vite client-manifest keys are always posix, so they never match: SSR hydration preloads silently miss and SolidJS server lazy() breaks. The test fails on Windows today and pins the invariant before the fix lands.
node:path relative() emits Windows separators, which never match Vite's always-posix client-manifest keys — SSR hydration preloads miss and server lazy() breaks. Every other path in the pipeline is already normalized through normalizePath(); these two sites were the only ones missed. Turns the regression test from the previous commit green on Windows.
brenelz
approved these changes
Sep 3, 2026
brenelz
reviewed
Sep 3, 2026
| expect(code.match(/pick=default&pick=\$css&lang\.tsx'\)/g)?.length).toBe(2); | ||
| }); | ||
|
|
||
| it("serializes lazy-ref src values with forward slashes", async () => { |
Contributor
There was a problem hiding this comment.
does this actually test something with forward slashes or am i missing something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6