Skip to content

Normalize lazy-ref src values #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mersho wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Normalize lazy-ref src values #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69e5cf7
test: lazy-ref src values must serialize with forward slashes
Mersho Aug 26, 2026
745ffdf
fix: normalize lazy-ref src values to posix separators
Mersho Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vite/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,12 @@ export function fileRoutes(options: FileRoutesOptions = {}): PluginOption[] {
// plus the `src` lazy refs already expose.
if (!codeSplitting) {
return {
src: relative(root, buildId),
src: normalizePath(relative(root, buildId)),
require: `_$() => (${js.addNamespaceImport(buildId)})$_`
};
}
return {
src: relative(root, buildId),
src: normalizePath(relative(root, buildId)),
build: isBuild ? `_$() => import('${buildId}')$_` : undefined,
import: `_$() => import('${buildId}')$_`
};
Expand Down
14 changes: 14 additions & 0 deletions test/vite.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ describe("fileRoutes vite plugin", () => {
expect(code.match(/pick=default&pick=\$css&lang\.tsx'\)/g)?.length).toBe(2);
});

it("serializes lazy-ref src values with forward slashes", async () => {

@brenelz brenelz Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually test something with forward slashes or am i missing something

const directory = createRouteTree({
"index.tsx": "export default () => <h1>Home</h1>;"
});

const split = await loadVirtualModule(directory);
const eager = await loadWith(createPlugin(directory, { codeSplitting: false }), directory);

expect(split).toContain('"src"');
expect(eager).toContain('"src"');
expect(split).not.toContain("\\");
expect(eager).not.toContain("\\");
});

it("resolves only the virtual module id", async () => {
const [plugin] = fileRoutes() as any[];
expect(moduleId).toBe("virtual:file-routes");
Expand Down
Loading