Skip to content

Update style requirements in preparation for Ruff linter#115

Merged
kwryankrattiger merged 2 commits intospack:mainfrom
kwryankrattiger:moving_to_ruff
Apr 13, 2026
Merged

Update style requirements in preparation for Ruff linter#115
kwryankrattiger merged 2 commits intospack:mainfrom
kwryankrattiger:moving_to_ruff

Conversation

@kwryankrattiger
Copy link
Copy Markdown
Collaborator

Keep old requirements for black/isort/flake8/ for transition Adds Ruff

@adamjstewart
Copy link
Copy Markdown
Member

I would suggest we instead add both black/isort/flake8 and ruff in spack/spack and/or spack/spack-packages so we ensure that spackbot stays up-to-date with spack. Dependabot will eventually start updating things out of order and break something.

@kwryankrattiger
Copy link
Copy Markdown
Collaborator Author

I would suggest we instead add both black/isort/flake8 and ruff in spack/spack and/or spack/spack-packages so we ensure that spackbot stays up-to-date with spack. Dependabot will eventually start updating things out of order and break something.

So I took another approach. I am disabling Style in core, leaving it untouched for packages. This adds the ruff to the image.

When things are merged for core, we just uncomment disabling style.

For packages, this is all handled by the .ci/style-check.sh script which we can update whenever we update package style.

Keep old requirements for black/isort/flake8/ for transition
Adds Ruff
@kwryankrattiger kwryankrattiger merged commit eec2ef7 into spack:main Apr 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants