Skip to content

Update style requirements in preparation for Ruff linter #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwryankrattiger merged 2 commits into from
Apr 13, 2026
Merged

Update style requirements in preparation for Ruff linter #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa50326
Update style requirements in preparation for Ruff linter
kwryankrattiger Apr 10, 2026
565ec4c
Disable style for core
kwryankrattiger Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spackbot/workers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,12 @@ async def fix_style_task(event):
# Style tool is run from the root dir expressed as {0}
upstream_url = helpers.PROJECTS[repo_name].upstream_url
if repo_name == "spack":
await gh.post(
event.data["issue"]["comments_url"], {}, data={"body": "Spackbot style is disabled while transitioning to Ruff"}
)
logger.info("Skipping style for core")
return

style_tool = (
"bin/spack",
["--color", "never", "style", "--fix", "--root", "{0}"],
Expand Down
2 changes: 1 addition & 1 deletion workers/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM python:3.14

ADD https://raw.githubusercontent.com/spack/spack/refs/heads/develop/.github/workflows/requirements/style/requirements.txt /source/style-requirements.txt
COPY workers/requirements.txt /source/requirements.txt
COPY workers/style-requirements.txt /source/style-requirements.txt

RUN pip3 install --upgrade pip setuptools wheel && \
pip3 install -r /source/requirements.txt && \
Expand Down
12 changes: 12 additions & 0 deletions workers/style-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
black==25.12.0
clingo==5.8.0
flake8==7.3.0
isort==7.0.0
mypy==1.20.0
types-six==1.17.0.20251009
vermin==1.8.0
pylint==4.0.5
docutils==0.22.4
ruamel.yaml==0.19.1
slotscheck==0.19.1
ruff==0.15.7
Loading