Repository navigation
feat: add an attested build-module reusable workflow - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
build-module, a reusable workflow that builds, packs and attests a Spicetify module from the commit that called it. The attestation names this workflow as its signer, so the registry can verify a submitted zip was produced by these steps, on a GitHub-hosted runner, from one commit of the author's repository. An AI reviewer can then read the source at that commit instead of the bundled output.id-token): installs from the committed lockfile (npm, pnpm, or bun) with install scripts and pnpm's.pnpmfile.cjshooks skipped, runsspicetify-kit buildfrom the npm registry at the version the lockfile resolved (from an empty directory, so a project.npmrccannot swap the kit or setscript-shell), and packs the zip.--clobber.publishgains azipinput so the attested bytes are submitted byte for byte instead of being re-packed.test-build-moduleruns the workflow on a fixture module and verifies the result withgh attestation verify --signer-workflow spicetify/actions/.github/workflows/build-module.yml --deny-self-hosted-runners, checking the subject digest and source commit.The registry side is spicetify/modules#58:
validate-submission.tsverifies these attestations, and Pullfrog reviews the source at the attested commit.Validation
actionlintpasses on every workflow;zizmorreports nothing above low on the new files.zipthe checksum is preserved,diststill packs, and neither input fails with an error.test-build-modulerun is the first real build, attestation, and verification.Release
Authors reference
@v1, so the workflow becomes usable after av1.x.ytag movesv1. The kit's project template should only point at it after that release.