Repository navigation
feat: verify build attestations and review submissions with Pullfrog - #58
Merged
Merged
Conversation
afonsojramos
marked this pull request as ready for review
October 9, 2026 22:12
Contributor
|
This run was cancelled 🛑 The workflow was cancelled before completion. Please check the link below for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Every store submission now gets an AI security review that reads the source the zip was actually built from.
validate-submission.tsverifies each new artifact's attestation withgh attestation verify, requiring thespicetify/actionsbuild-moduleworkflow as signer, a GitHub-hosted runner, and the repository named in the artifact's ownmetadata.repository. It reports the source commit, or why the artifact is unverified. The check is informational: an unattested module still validates.provenanceartifact.pull_request_targetworkflow recomputes provenance from base-branch code, reading the pull request only as data, then runs Pullfrog with a committed prompt (.github/submission-review.md). The reviewer clones the author's repository at the attested commit, or unpacks the artifact when there is no attestation, checks it against a Spicetify-specific list (network access, remote and dynamic code, Spotify credentials, the daemon token and CORS proxy, module-installing localStorage writes, concealment, supply chain, loader hangs), and posts one review that never approves. Pullfrog runs withpush: disabledandshell: restricted, and every action in this workflow is pinned by SHA because it holds model keys on fork pull requests.docs/publishing.mddescribes attested builds and the review.Builder side: spicetify/actions#4.
Validation
pnpm fmt:check,pnpm check, and the fullpnpm testpass (816 passed, 29 skipped); the validator suite has 30 tests, including parsing of a realghverification result.verifyWithGhagainst real artifacts: Add section-marker-rev to vault #55 reports no attestation; the CLI's own release binary reports it was signed byrust-release.yml, notbuild-module.actionlintpasses;zizmorreports nothing onsubmission-review.yml.Not yet exercised:
build-moduleattestation passing the validator, which needs the builder PR's run.pull_request_targetandworkflow_dispatchboth read the workflow from the default branch, so the first run happens after merge;workflow_dispatchwith a pull request number then re-reviews open submissions such as Add section-marker-rev to vault #55.