Skip to content

chore(classmap): remove the pre-pipeline 1.2.38, 1.2.40 and 1.2.45 keys - #19

Merged
afonsojramos merged 2 commits into
mainfrom
chore/remove-legacy-keys
Sep 30, 2026
Merged

afonsojramos merged 2 commits into
mainfrom
chore/remove-legacy-keys

Conversation

@afonsojramos

@afonsojramos afonsojramos commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Removes 1020038, 1020040 and 1020045. They predate the verification pipeline and have no META or verification history. 1020045 also had two hyphenated leaves that modules couldn't reference.
  • Every remaining key is verified, so the validator now requires META.json and VERIFICATION.md in each key directory.
  • 1020092 still records derived from 1020040 in its META. That field is history; the validator only checks that an inherited source exists.

Effect on users

Clients on Spotify 1.2.38–1.2.45 no longer get a classmap from this repository, so module class references can't resolve there. Since v3 only treats verified keys as supported builds, those clients were already unsupported.

Verification

pnpm check passes: 10 keys, 61 tests.

Summary by CodeRabbit

  • Documentation
    • Clarified that every indexed entry must include metadata and verification documentation.
  • Chores
    • Removed three legacy entries from the published index and removed their associated mappings.
    • Updated validation to report missing metadata or verification documentation, with tests covering these cases.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ba571388-d243-4396-adbf-453ca5ece9a2

📥 Commits

Reviewing files that changed from the base of the PR and between 11cc417 and 54a658f.

📒 Files selected for processing (7)
  • 1020038/classmap.json
  • 1020040/classmap.json
  • 1020045/classmap.json
  • README.md
  • index.json
  • scripts/validate-classmaps.test.mts
  • scripts/validate-classmaps.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fd95278e-f690-4521-a058-a6be95975622

📥 Commits

Reviewing files that changed from the base of the PR and between 92c401a and 11cc417.

📒 Files selected for processing (7)
  • 1020038/classmap.json
  • 1020040/classmap.json
  • 1020045/classmap.json
  • README.md
  • index.json
  • scripts/validate-classmaps.test.mts
  • scripts/validate-classmaps.ts
💤 Files with no reviewable changes (4)
  • index.json
  • 1020045/classmap.json
  • 1020038/classmap.json
  • 1020040/classmap.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The validator now requires META.json and VERIFICATION.md for each key. The index and classmap data for keys 1020038, 1020040, and 1020045 were removed.

Changes

Classmap key requirements

Layer / File(s) Summary
Require metadata and verification files
scripts/validate-classmaps.ts, scripts/validate-classmaps.test.mts, README.md
The validator reports missing META.json and VERIFICATION.md files. Tests cover missing files, and the README marks both files as required for every key.
Remove legacy classmap keys
index.json, 1020038/classmap.json, 1020040/classmap.json, 1020045/classmap.json
The index entries and classmap files for keys 1020038, 1020040, and 1020045 were removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 11cc4

The change removes three legacy classmaps and requires metadata and verification files for remaining keys. No actionable merge-blocking risk is evident in the supplied context.

Architecture Summary

Architecture risk: 🔵 Low · up to 11cc4

The change affects 6 systems.

Changed systems: scripts, 1020038, 1020040, 1020045, index.json, README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scripts (service) was modified; 2 changed files map to changed impact.
  • observed — 1020038 (service) was modified; 1 changed file maps to changed impact.
  • observed — 1020040 (service) was modified; 1 changed file maps to changed impact.
  • observed — 1020045 (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in 1020038/classmap.json: The 1020038/classmap.json file was removed, including its mappings for playbar button wrapper, active, and indicator classes, and topbar left/right button and icon wrappers.
  • observed — Modified behavior in 1020040/classmap.json: The entire class-name mapping JSON was removed, including mappings for context-menu items, main navigation and player controls, modals, search, settings, sorting, and track-list elements.
  • observed — Modified behavior in 1020045/classmap.json: The 1020045/classmap.json file was removed, including its mappings from UI element names to generated class identifiers.
  • observed — Modified behavior in README.md: The file table now marks META.json and VERIFICATION.md as required for every key, replacing the prior conditional requirements.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removal of the three pre-pipeline classmap keys.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each key at dawn,
For missing files, it marks the flaw.
Three old maps hop out of sight,
The index trims its list just right.
Then carrots crunch beneath the moon.

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos force-pushed the chore/remove-legacy-keys branch from 11cc417 to 54a658f Compare September 30, 2026 11:54
@afonsojramos
afonsojramos merged commit 556cd17 into main Sep 30, 2026
2 checks passed
@afonsojramos
afonsojramos deleted the chore/remove-legacy-keys branch September 30, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant