fix(scripts): reach every classmap surface in the deep CDP run - #3977
Merged
Merged
Conversation
…he deep CDP run Steps now wait for what they open. The menu opens on a main-view track row instead of a Your Library row, credits and embed open from it, Settings opens through the account menu because a pushed history entry doesn't render it, and native <dialog> elements count as open dialogs. On stock 1.3.1 the deep run observes 32/36 leaves with 10/10 steps, up from 23/36 and 7/8.
The previous defaults migrated from 1020040, which spicetify/classmaps no longer publishes, and wrote into the CLI checkout. The base now defaults to the newest key, BASE_SPA or BASE_CSS_DIR is required to migrate, and output goes to a temporary directory.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: spicetify/cli/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="row"it found was a Your Library sidebar row.<dialog>elements, which now count as open dialogs, and each step closes the previous one's dialog first./preferencesontohistory, which changes the URL without rendering Settings, so its probes never saw a section.classmap-e2e.shdefaults: they pointed at 1020040, which chore(classmap): remove the pre-pipeline 1.2.38, 1.2.40 and 1.2.45 keys classmaps#19 removes, and wrote into the CLI checkout. The base classmap now defaults to the newest key, a stockBASE_SPAorBASE_CSS_DIRis required to migrate, and output goes to$TMPDIR/spicetify-classmap-e2e.Menu labels are matched in English.
Verification