Skip to content

feat(classmap): publish 1030003 for Spotify 1.3.3, inherited from 1030001 - #24

Merged
afonsojramos merged 1 commit into
mainfrom
keys/1030003-inherit
Oct 1, 2026
Merged

afonsojramos merged 1 commit into
mainfrom
keys/1030003-inherit

Conversation

@afonsojramos

@afonsojramos afonsojramos commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

This publishes key 1030003 for Spotify 1.3.3.264 (macOS), inherited from 1030001.

  • Static verify against the stock 1.3.3 archive found no hashed class missing. The only missing class belongs to settings.header.container, which 1030001 already records as unverified.
  • The deep CDP run on an applied 1.3.3.264 client passes. Its misses are the three search_chips Encore leaves, which are statically verified as in 1030001, and settings.header.container.
  • The watcher didn't open an issue because 1.3.3 isn't on the Linux apt channels yet.

The platform contract on 1.3.3 caught a broken context menu lookup in the wrapper, which is fixed in spicetify/cli#4002.

Summary by CodeRabbit

  • Compatibility Updates
    • Added verified support for Spotify version 1.3.3.264, improving compatibility across playback controls, navigation, search, settings, and other interface elements.
    • Updated interface styling and layout recognition for this version.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 503531e2-ace9-4538-8f0d-d0ba47d30b56

📥 Commits

Reviewing files that changed from the base of the PR and between dfe3a82 and 3a9c0fc.

📒 Files selected for processing (5)
  • 1030003/META.json
  • 1030003/VERIFICATION.md
  • 1030003/classmap.json
  • 1030003/css-map.json
  • index.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

This change adds classmap 1030003 for Spotify 1.3.3.264. It includes UI class mappings, CSS identifier mappings, verification records, metadata, and an index entry that marks the classmap as verified.

Changes

Spotify 1.3.3.264 classmap

Layer / File(s) Summary
Add UI and CSS mappings
1030003/classmap.json, 1030003/css-map.json
Adds class mappings for listed UI components and maps 292 generated identifiers to CSS class names.
Record verification and register classmap
1030003/META.json, 1030003/VERIFICATION.md, index.json
Records the classmap metadata and verification results, then adds the verified 1030003 entry to the index.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 3a9c0

The new classmap registration and its artifacts are internally consistent, with no concrete merge-blocking issue established.

Architecture Summary

Architecture risk: 🔵 Low · up to 3a9c0

The change affects 2 systems.

Changed systems: 1030003, index.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — 1030003 (service) was modified; 4 changed files map to changed impact.
  • observed — index.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in 1030003/META.json: Added metadata for classmap 1030003, including its source, version, verification status and hash, required-path states, and unverified leaf.
  • observed — Modified behavior in 1030003/VERIFICATION.md: Adds a verification record stating that 32 of 36 paths were present in target CSS and verified by deep CDP, with 3 additional live-only paths and 1 unresolved missing path. It records 10 of 10 successful navigation steps, publication statistics, evidence hashes, and the CDP report generation time.
  • observed — Modified behavior in 1030003/classmap.json: Adds the class-map configuration for the listed UI components, assigning each mapped element its configured class names.
  • observed — Modified behavior in 1030003/css-map.json: Adds a JSON mapping of 292 generated identifiers to CSS class names; the old hunk contains no entries.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: publishing classmap key 1030003 for Spotify 1.3.3 with inheritance from 1030001.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit maps the classes neat,
Then checks the paths with careful feet.
The CSS names line up in rows,
The index marks the version it knows.
One leaf stays open, still to check,
The rabbit hops back to its deck.

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos merged commit efb0755 into main Oct 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant