Reset pitch bend to zero at note end - #202
Open
BeratYilmaz-dev wants to merge 1 commit into
Open
BeratYilmaz-dev wants to merge 1 commit into
BeratYilmaz-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87.
Currently, when pitch bends are estimated for a note event, the pitch bend wheel is never reset back to neutral (0) when the note ends. Because pitch bend is a stateful channel controller in MIDI, any subsequent notes played on that instrument remain detuned.
This PR spaces intra-note pitch bend events across
[start_time, end_time)and appends aPitchBend(0, end_time)event when a note with non-zero bend concludes. Added unit tests intest_note_creation.py.