Skip to content

Reset pitch bend to zero at note end #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BeratYilmaz-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reset pitch bend to zero at note end #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion basic_pitch/note_creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def note_events_to_midi(
instrument.notes.append(note)
if not pitch_bend:
continue
pitch_bend_times = np.linspace(start_time, end_time, len(pitch_bend))
pitch_bend_times = np.linspace(start_time, end_time, len(pitch_bend), endpoint=False)
pitch_bend_midi_ticks = np.round(np.array(pitch_bend) * PITCH_BEND_SCALE / CONTOURS_BINS_PER_SEMITONE).astype(
int
)
Expand All @@ -266,6 +266,8 @@ def note_events_to_midi(
pitch_bend_midi_ticks[pitch_bend_midi_ticks < -N_PITCH_BEND_TICKS] = -N_PITCH_BEND_TICKS
for pb_time, pb_midi in zip(pitch_bend_times, pitch_bend_midi_ticks):
instrument.pitch_bends.append(pretty_midi.PitchBend(pb_midi, pb_time))
if pitch_bend_midi_ticks[-1] != 0:
instrument.pitch_bends.append(pretty_midi.PitchBend(0, end_time))
mid.instruments.extend(instruments.values())

return mid
Expand Down
20 changes: 19 additions & 1 deletion tests/test_note_creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from basic_pitch.note_creation import drop_overlapping_pitch_bends
from basic_pitch.note_creation import drop_overlapping_pitch_bends, note_events_to_midi


def test_drop_overlapping_pitch_bends() -> None:
Expand Down Expand Up @@ -48,3 +48,21 @@ def test_drop_overlapping_pitch_bends() -> None:
]
result = drop_overlapping_pitch_bends(note_events_with_pitch_bends)
assert sorted(result) == sorted(expected)


def test_note_events_to_midi_pitch_bend_reset() -> None:
note_events = [
(0.0, 1.0, 60, 1.0, [0, 1]),
(2.0, 3.0, 62, 1.0, None),
]
mid = note_events_to_midi(note_events)
pitch_bends = mid.instruments[0].pitch_bends
assert len(pitch_bends) > 0
assert pitch_bends[-1].pitch == 0
assert pitch_bends[-1].time == 1.0

mid_multi = note_events_to_midi(note_events, multiple_pitch_bends=True)
inst_60 = [inst for inst in mid_multi.instruments if any(n.pitch == 60 for n in inst.notes)][0]
assert len(inst_60.pitch_bends) > 0
assert inst_60.pitch_bends[-1].pitch == 0
assert inst_60.pitch_bends[-1].time == 1.0