fix(docs): Add required TLS and fix stale fields in S3 examples - #919
Open
sweb wants to merge 2 commits into
Open
fix(docs): Add required TLS and fix stale fields in S3 examples#919sweb wants to merge 2 commits into
sweb wants to merge 2 commits into
Conversation
sweb
force-pushed
the
fix/tls-s3-examples
branch
from
July 28, 2026 13:57
9f9f00e to
53650ff
Compare
sweb
marked this pull request as ready for review
July 28, 2026 13:58
sbernauer
reviewed
Jul 28, 2026
Comment on lines
+10
to
+14
| No configuration change is applied until the connection is fixed, including changes unrelated to S3. | ||
| The Stacklet keeps running with its previous configuration and still reports the `Available` condition as `True`, and no Kubernetes event is emitted. | ||
| Check the logs of the Trino operator if a catalog or a configuration change appears to have no effect. | ||
| Adding the missing `tls` section is enough to recover; the pending changes are applied within seconds. | ||
| This applies to both of the forms shown below. |
Member
There was a problem hiding this comment.
To be honest this sounds a bit verbose to me as it's not S3 specific at all, but a general platform thing. I would be in favor of removing it or placing it somewhere more "central" in the docs
Member
Author
There was a problem hiding this comment.
You are right - addressed in e59e1c3
I missed that there is an event on the TrinoCluster - without noticing this, the failing reconciliation felt way more concerning than it actually is.
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes s3 connection examples to use TLS
Definition of Done Checklist
Author
Reviewer
Acceptance