fix: mcp.json server-path gate selects the ${PLUGIN_ROOT} arg instead of joining args - #25
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: mcp.json server-path gate selects the ${PLUGIN_ROOT} arg instead of joining args#25devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
… joining args Joining every arg made an empty args list resolve to the repo root (gate passed on a manifest naming no server file) and made a legitimate multi-arg invocation resolve to a bogus path.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24, from a Devin Review finding on the conformance gate. The gate that proves
mcp.jsonpoints at a real server file derived its path by joining all args, which fails in both directions:Now it picks the one
${PLUGIN_ROOT}-relative arg and fails loudly when there isn't one:Verified by mutating
mcp.jsonand runningnode bin/check.jseach time:args[]${PLUGIN_ROOT}-relative server path['--enable-source-maps', '${PLUGIN_ROOT}/…/server.js']['${PLUGIN_ROOT}/mcp/nope.js']mcp/nope.jsnpm run check: 74/74 tests pass. Gate-only change; no runtime behavior touched.Link to Devin session: https://app.devin.ai/sessions/f135381c4682413bae73dff38eb6d1a3
Requested by: @suboss87