Skip to content

fix: mcp.json server-path gate selects the ${PLUGIN_ROOT} arg instead of joining args #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: Main
Choose a base branch
from
+3 −1
Open

fix: mcp.json server-path gate selects the ${PLUGIN_ROOT} arg instead of joining args #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,8 +402,10 @@ if (apMcp.$schema !== AP_MCP_SCHEMA) {
}
}
const ingest = apServers['fdeops-ingest']
const target = ingest && (ingest.args || []).join(' ').replace('${PLUGIN_ROOT}/', '')
const rootArg = ingest && (ingest.args || []).find(a => String(a).startsWith('${PLUGIN_ROOT}/'))
const target = rootArg && String(rootArg).replace('${PLUGIN_ROOT}/', '')
if (!ingest) fail('mcp.json must declare the fdeops-ingest stdio server')
else if (!target) fail('mcp.json fdeops-ingest must pass a ${PLUGIN_ROOT}-relative server path in args')
else if (!fs.existsSync(path.join(root, target))) fail(`mcp.json fdeops-ingest points at missing ${target}`)
else ok('agent plugins mcp config')
}
Expand Down
Loading