Allow binding multiple addresses#79
Merged
Merged
Conversation
aryan-25
reviewed
May 13, 2026
gjcairo
force-pushed
the
multiple-addresses
branch
from
76df44e to
4b38661
Compare
gjcairo
force-pushed
the
multiple-addresses
branch
from
7db71c8 to
1726688
Compare
aryan-25
approved these changes
May 18, 2026
aryan-25
left a comment
aryan-25
left a comment
Collaborator
There was a problem hiding this comment.
Some small suggestions, LGTM otherwise :)
FranzBusch
approved these changes
May 18, 2026
aryan-25
added a commit
that referenced
this pull request
Jun 3, 2026
Motivation: In #79, we introduced support for binding to multiple addresses. However, since all bound channels share a single `ServerQuiescingHelper`, this means only the *first* bound server channel supports graceful shutdown. In addition to this, due to the way #79 handles the cleanup of server channels, as soon as one channel finishes, all other channels are immediately shut down. This means that in-flight requests on every other listener are dropped immediately when `_serve` returns after the first listener finished. Since different channels may complete draining at different times, we should also fix this. Modifications: - Modified the HTTP/1.1 and secure upgrade channel setup methods to set up a `ServerQuiescingHelper` for each bound channel. - Modified the cases of the `ServerChannel` enum to store the associated `ServerQuiescingHelper`. - Modified the `beginGracefulShutdown` method to now iterate every listener and initiate shutdown on each. - Refactored the `_serve` task-group to wait for *all* listeners to finish, and only tear the whole server down on an error. - Added associated tests. Result: Graceful shutdown is now supported on every bound channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for binding a
NIOHTTPServerto multiple addresses simultaneously.The configuration API now also accepts an array of
BindTargets. All resulting channels are served concurrently using the same request handler.The server treats its listening addresses as a unit: if any channel stops serving for any reason, all remaining channels are are also cancelled. This behaviour matches the current behaviour with a single listening address.
The
listeningAddressproperty has been replaced bylisteningAddresses, an array of addresses.