-
Notifications
You must be signed in to change notification settings - Fork 5
chore: use journeys as prs qa contract #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ovitrif
wants to merge
9
commits into
master
Choose a base branch
from
chore/1249-journeys-qa-contract
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−61
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c2d6286
docs: use journeys as prs qa contract
ovitrif 0ffee1a
docs: list journey capabilities in readme
ovitrif ccd46da
docs: list only xml journeys in pr step 3
ovitrif 77f8e79
docs: add reviewer checkboxes to journeys and manual tests
ovitrif 7f1059c
Merge branch 'master' into chore/1249-journeys-qa-contract
ovitrif 8153514
docs: drop the hand-maintained journeys suites table
ovitrif c352ea6
Merge remote-tracking branch 'origin/chore/1249-journeys-qa-contract'…
ovitrif a45da5f
Merge remote-tracking branch 'origin/master' into chore/1249-journeys…
ovitrif d3ef661
Merge remote-tracking branch 'origin/master' into chore/1249-journeys…
ovitrif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user-visible change that no journey can drive has no valid
#### Journeysvalue.Line 153 tells
/prto stop when a user-visible change has no covering journey. The line above it makesN/A — no user-visible behaviour change.the only empty value. Line 203's style target lists a BLE pairing step under Manual Tests, andjourneys/README.mdsays BLE/USB are not simulated. So a PR whose only user-visible change is in BLE pairing or the USB permission flow either halts here or gets the falseN/A — no user-visible behaviour change.next to a manual test. The template's#### Journeyscomment at.github/pull_request_template.md:25has the same gap.Fix: allow an explicit value for this case, e.g.
N/A — not drivable; see Manual Tests., in bothpr.mdand the template. Mirror it on the iOS twin.