chore: use journeys as prs qa contract

[ovitrif]

Closes #1249

Counterpart: synonymdev/bitkit-ios#743

Description

• Makes #### Journeys the first QA Notes section so that a PR with a user-visible change lists the journeys that prove it, by bare file name with new or updated, and reviewers drive them on a device instead of reading prose.
• Limits #### Manual Tests to steps that need a capability the journey environment lacks, and adds a ## Capabilities table to journeys/README.md as the authority for what it provides, so a step is manual by evidence, not by category.
• Shapes #### Automated Checks as a flat list with added, updated, removed, and ran keywords so the same prefix is never repeated.
• Applies the rules in /pr and states them in AGENTS.md, and lists the android CLI with the android-cli skill under Prerequisites because it is how an agent drives journeys.

Out of Scope

• journeys/: drift tooling, an identifier index, or a CI check; a journey that fails at review is the drift signal.
• A shared journeys skill giving iOS and Android one driving procedure; each platform names its own driver.
• Past manual tests from merged PRs: kept as a backlog in chore: keep past manual tests as a journeys backlog #1307.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

• ran a per-file diff of the added lines against the counterpart PR: only platform names, test-file types, the driver, and Capabilities rows differ
• ran a diff of the ### QA Notes template section against the counterpart: identical apart from the example test-file name
• ran the review skill's parser tests against the new #### Journeys and #### Automated Checks formats: bare names resolve on the PR head, legacy full paths still parse
• ran every Capabilities row back to the suite README or preconditions section it cites

[github-actions]

Regtest APK

Built from d3ef661 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with a non-blocking issue where journey discovery can misclassify documentation files as executable journeys.

Findings

1.  Documentation Becomes A Journey ▶

Summary

This PR makes device-driven journeys the primary QA contract for user-visible changes and aligns the PR command, template, contributor guidance, and journey documentation.

• Adds Journeys as the first QA Notes section.
• Restricts manual tests to capabilities absent from the journey environment.
• Standardizes automated-check entries around added, updated, removed, and ran.
• Documents the Android tooling prerequisites and available journey capabilities.

_{Reviews (2) · Last reviewed commit: "docs: list journey capabilities in readm..."}

[jvsena42]

the Journeys readme is causing conflicts on every Pr merge, can we remove it or use something similar to the changeling strategy?

[jvsena42]

One MEDIUM on the QA contract rules (inline). It is docs-only, so it doesn't block. The same gap is on the iOS twin, synonymdev/bitkit-ios#743.

Checked and clean:

• CLAUDE.md→AGENTS.md symlink: the old "not a QA gate" wording is gone everywhere. QA gate and developer-assistance grep clean.
• The Suites table removal leaves no dangling #suites references.
• Every Capabilities link target exists at head.
• pr.md Step 3 discovery and the \.xml$ filter are in place.
• The pr.md structure and style target match the template headings and order.
• The library-repo example's Journeys omission is intentional.

The missing locale/font-scale and run-as rows in Capabilities looked like gaps, but the shell-command rule at journeys/README.md:39 covers them, so I'm not raising them.

[jvsena42]

A user-visible change that no journey can drive has no valid #### Journeys value.

Line 153 tells /pr to stop when a user-visible change has no covering journey. The line above it makes N/A — no user-visible behaviour change. the only empty value. Line 203's style target lists a BLE pairing step under Manual Tests, and journeys/README.md says BLE/USB are not simulated. So a PR whose only user-visible change is in BLE pairing or the USB permission flow either halts here or gets the false N/A — no user-visible behaviour change. next to a manual test. The template's #### Journeys comment at .github/pull_request_template.md:25 has the same gap.

Fix: allow an explicit value for this case, e.g. N/A — not drivable; see Manual Tests., in both pr.md and the template. Mirror it on the iOS twin.