fix: polish wallet ui by pwltr · Pull Request #1270 · synonymdev/bitkit-android

pwltr · 2026-09-15T13:07:30Z

Description

This PR polishes the current wallet UI stack:

Aligns button text styles, small button sizing, scanner/send icon button backgrounds, selected tab indicator color, and money symbol styling.
Tightens amount screen, transfer flow, wallet activity, invoice tag, receive confirmation, boost sheet, and activity detail spacing/typography.
Updates onboarding/settings intro copy, translations, sheet intro layout behavior, and restore wallet mnemonic emphasis.
Keeps a changelog fragment for the wallet polish work and restores the existing incoming payment request fragment from master.

Design

Mapped screen references are listed in docs/screens-map.md for the touched screens, including:

HomeScreen.kt → Wallet On-chain › Wallet BTC
SavingsWalletScreen.kt → Savings, Spending, Hardware Balances › Savings Populated
SpendingWalletScreen.kt → Savings, Spending, Hardware Balances › Spending Ready
SpendingAmountScreen.kt / SpendingAdvancedScreen.kt / SpendingConfirmScreen.kt → Transfer to Spending Balance From Savings frames
EditInvoiceScreen.kt / ReceiveConfirmScreen.kt / ReceiveQrScreen.kt → receive/send invoice frames
ActivityDetailScreen.kt / AllActivityScreen.kt → transaction/activity frames
RestoreWalletScreen.kt / OnboardingSlidesScreen.kt / CreateWalletScreen.kt → onboarding frames
BackupIntroScreen.kt / QuickPayIntroScreen.kt → settings intro frames

Out-of-map sheets and shared components were cross-checked against the existing iOS implementation and user-provided screenshots during implementation.

Preview

QA Notes

Manual Tests

Open the wallet home screen and verify the section spacing between balances, activity, and action areas remains visually consistent.
Open Savings and Spending wallet screens and verify the transfer button has the intended space before the first activity row.
Walk through the transfer-to-spending amount, advanced, and confirm screens; verify title/amount spacing, number pad spacing, amount symbols, and coin image tilt on slider drag.
Open receive invoice editing and verify tags sit in the same row as the add tag button, note/add-tag input styling matches, and selected tag spacing is correct.
Open transaction details and the boost sheet; verify the boost icon, fee amount symbol, long duration text, outline suggested-fee button, and single top toast behavior.
Walk through onboarding/settings intro screens and restore wallet; verify copy, translations, sheet image placement, and focused mnemonic word weight.

Automated Checks

./gradlew compileDevDebugKotlin

pwltr · 2026-09-15T13:13:33Z

-                        } else {
-                            Modifier.graphicsLayer {
-                                colorFilter = ColorFilter.tint(Colors.White32)
+    CompositionLocalProvider(LocalMinimumInteractiveComponentSize provides 0.dp) {


This fixed small button text and disabled styles

pwltr · 2026-09-18T11:22:48Z

This PR is mostly visual polish across wallet, transfer, receive, onboarding, and settings screens: spacing, typography, colors, icons, animations, localized copy, and currency-symbol consistency.

Changes worth focused review:

The shared button component now applies size-specific typography and removes Material’s minimum interactive height so small buttons remain the intended height in every state.
The boost sheet displays a localized, long-form duration for its fee estimate. This does not change fee calculation or selection.
The scanner hides its back button when opened from the tab bar; other scanner entry points retain it.

No wallet, payment-execution, persistence, or networking logic is changed.

greptile-apps · 2026-09-18T11:26:24Z

Confidence Score: 4/5

The PR appears safe to merge after non-blocking presentation and localization inconsistencies are addressed.

Findings

Fee rate uses money format ▶
Instant duration lacks translations ▶

Summary

This PR broadly polishes the wallet UI, including shared typography and money presentation, transfer and receive layouts, scanner and activity styling, onboarding copy, localized resources, and boost-fee presentation.

Adds fee-duration resources and uses them in transaction boosting.
Refines shared buttons, amount fields, tabs, tags, icons, and activity spacing.
Updates receive, transfer, onboarding, settings, and scanner surfaces.
Adds a changelog fragment covering the wallet UI polish.

_{Reviews (1) · Last reviewed commit: "fix: restore changelog fragment"}

github-actions · 2026-09-18T13:46:30Z

Regtest APK

Built from 897ade6 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

ovi-reviewer

Verdict: ✅ Approve

Review: diff 72 files.

Findings:
6 inline (non-blocking)

Audit:
Audited - no findings.

Reviewed by gpt-5.6-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest · audit (author or owner)

ovi-reviewer

Verdict: ✅ Approve

Reaudit: diff 10 files.

Findings:
N/A

Audit:
Already done in comment.

Coverage:
Unit tests: 85% - ButtonTest.kt covers button heights across states and AppViewModelSendFlowTest.kt covers scanner flag selection.

Reviewed by gpt-5.6-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest · audit (author or owner)

github-advanced-security Bot found potential problems Sep 15, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveConfirmScreen.kt Fixed

Comment thread app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveConfirmScreen.kt Fixed

pwltr commented Sep 15, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/components/BottomSheet.kt Outdated

pwltr commented Sep 15, 2026

View reviewed changes

jvsena42 mentioned this pull request Sep 17, 2026

fix: avoid animated switch to auto tab #1308

Open

6 tasks

pwltr force-pushed the fix/polish branch 3 times, most recently from 52c4d23 to 9ee2d2a Compare September 18, 2026 11:22

pwltr marked this pull request as ready for review September 18, 2026 11:22

pwltr enabled auto-merge (squash) September 18, 2026 11:23

greptile-apps Bot reviewed Sep 18, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/sheets/BoostTransactionSheet.kt Outdated

Comment thread app/src/main/java/to/bitkit/models/FeeRate.kt

pwltr disabled the stack merge September 18, 2026 13:51

pwltr added this pull request to stack #1315 September 18, 2026 13:51

pwltr requested review from jvsena42 and ovitrif September 18, 2026 14:32

ovi-reviewer Bot approved these changes Sep 18, 2026

View reviewed changes

pwltr added 12 commits September 19, 2026 14:51

fix(ui): add missing money symbols

bdd0e11

fix(ui): adjust scanner icon backgrounds

80d009b

fix: update tab indicator default

d10cb90

fix: polish receive amount ui

c91efb0

fix: polish transaction speed settings ui

687dfd6

fix: polish small activity buttons

c04ca39

fix: polish invoice tag inputs

6a5517a

fix: polish boost sheet

9734553

fix: align amount keypad spacing

e3f5932

fix: polish transfer flow layout

d213ec5

fix: align home activity spacing

e37d403

fix: align button text styles

d59f76f

pwltr added 17 commits September 19, 2026 14:51

fix: tighten onboarding copy spacing

8d88252

fix: adjust restore mnemonic text weight

7df8d82

fix: polish settings intro layout

6b34633

fix: update onboarding copy translations

69e7369

fix: add wallet polish changelog

bbd724b

fix: address wallet polish review

c438e90

fix: remove unrelated changelog fragment

db4e762

fix: polish wallet loading animation

1fd1538

fix: replace material arrow icons

a19bb16

fix: hide scanner back button from tab bar

6e78672

fix: align wallet activity footer spacing

2ec036f

fix: align transfer progress footer spacing

0e4c7b9

fix: match send address field background

88b06e0

fix: align activity tag filter sheet

d271c62

fix: restore changelog fragment

f547fa7

fix: address boost sheet review feedback

a25c003

fix: address polish review feedback

897ade6

pwltr force-pushed the fix/polish branch from 0f69a7a to 897ade6 Compare September 19, 2026 13:00

ovi-reviewer Bot approved these changes Sep 19, 2026

View reviewed changes

Navigation Menu

fix: polish wallet ui - #1270

fix: polish wallet ui#1270
pwltr wants to merge 29 commits into
masterfrom
fix/polish

pwltr commented Sep 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwltr Sep 15, 2026

Uh oh!

pwltr commented Sep 18, 2026

Uh oh!

greptile-apps Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

ovi-reviewer Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovi-reviewer Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pwltr commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Design

Preview

QA Notes

Manual Tests

Automated Checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwltr Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

pwltr commented Sep 18, 2026

Uh oh!

greptile-apps Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regtest APK

Uh oh!

ovi-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovi-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pwltr commented Sep 15, 2026 •

edited

Loading

greptile-apps Bot commented Sep 18, 2026 •

edited

Loading

github-actions Bot commented Sep 18, 2026 •

edited

Loading