-
Notifications
You must be signed in to change notification settings - Fork 5
fix: polish wallet ui #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
fix: polish wallet ui #1270
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
bdd0e11
fix(ui): add missing money symbols
pwltr 80d009b
fix(ui): adjust scanner icon backgrounds
pwltr d10cb90
fix: update tab indicator default
pwltr c91efb0
fix: polish receive amount ui
pwltr 687dfd6
fix: polish transaction speed settings ui
pwltr c04ca39
fix: polish small activity buttons
pwltr 6a5517a
fix: polish invoice tag inputs
pwltr 9734553
fix: polish boost sheet
pwltr e3f5932
fix: align amount keypad spacing
pwltr d213ec5
fix: polish transfer flow layout
pwltr e37d403
fix: align home activity spacing
pwltr d59f76f
fix: align button text styles
pwltr 8d88252
fix: tighten onboarding copy spacing
pwltr 7df8d82
fix: adjust restore mnemonic text weight
pwltr 6b34633
fix: polish settings intro layout
pwltr 69e7369
fix: update onboarding copy translations
pwltr bbd724b
fix: add wallet polish changelog
pwltr c438e90
fix: address wallet polish review
pwltr db4e762
fix: remove unrelated changelog fragment
pwltr 1fd1538
fix: polish wallet loading animation
pwltr a19bb16
fix: replace material arrow icons
pwltr 6e78672
fix: hide scanner back button from tab bar
pwltr 2ec036f
fix: align wallet activity footer spacing
pwltr 0e4c7b9
fix: align transfer progress footer spacing
pwltr 88b06e0
fix: match send address field background
pwltr d271c62
fix: align activity tag filter sheet
pwltr f547fa7
fix: restore changelog fragment
pwltr a25c003
fix: address boost sheet review feedback
pwltr 897ade6
fix: address polish review feedback
pwltr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
100 changes: 100 additions & 0 deletions
100
app/src/androidTest/java/to/bitkit/ui/components/ButtonTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| package to.bitkit.ui.components | ||
|
|
||
| import androidx.compose.foundation.layout.Column | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.platform.testTag | ||
| import androidx.compose.ui.test.assertHeightIsEqualTo | ||
| import androidx.compose.ui.test.junit4.v2.createComposeRule | ||
| import androidx.compose.ui.test.onNodeWithTag | ||
| import androidx.compose.ui.unit.dp | ||
| import org.junit.Rule | ||
| import org.junit.Test | ||
| import to.bitkit.test.annotations.ComposeUi | ||
| import to.bitkit.ui.theme.AppThemeSurface | ||
|
|
||
| @ComposeUi | ||
| class ButtonTest { | ||
| @get:Rule | ||
| val composeTestRule = createComposeRule() | ||
|
|
||
| @Test | ||
| fun buttonHeightsRemainStableAcrossStates() { | ||
| composeTestRule.setContent { | ||
| AppThemeSurface { | ||
| Column { | ||
| PrimaryButton( | ||
| text = "Primary", | ||
| onClick = {}, | ||
| size = ButtonSize.Small, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("PrimarySmallEnabled") | ||
| ) | ||
| PrimaryButton( | ||
| text = "Primary", | ||
| onClick = {}, | ||
| size = ButtonSize.Small, | ||
| enabled = false, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("PrimarySmallDisabled") | ||
| ) | ||
| PrimaryButton( | ||
| text = "Primary", | ||
| onClick = {}, | ||
| size = ButtonSize.Small, | ||
| isLoading = true, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("PrimarySmallLoading") | ||
| ) | ||
| SecondaryButton( | ||
| text = "Secondary", | ||
| onClick = {}, | ||
| size = ButtonSize.Small, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("SecondarySmallEnabled") | ||
| ) | ||
| SecondaryButton( | ||
| text = "Secondary", | ||
| onClick = {}, | ||
| size = ButtonSize.Small, | ||
| enabled = false, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("SecondarySmallDisabled") | ||
| ) | ||
| SecondaryButton( | ||
| text = "Secondary", | ||
| onClick = {}, | ||
| size = ButtonSize.Small, | ||
| isLoading = true, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("SecondarySmallLoading") | ||
| ) | ||
| PrimaryButton( | ||
| text = "Primary", | ||
| onClick = {}, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("PrimaryLarge") | ||
| ) | ||
| SecondaryButton( | ||
| text = "Secondary", | ||
| onClick = {}, | ||
| fullWidth = false, | ||
| modifier = Modifier.testTag("SecondaryLarge") | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| listOf( | ||
| "PrimarySmallEnabled", | ||
| "PrimarySmallDisabled", | ||
| "PrimarySmallLoading", | ||
| "SecondarySmallEnabled", | ||
| "SecondarySmallDisabled", | ||
| "SecondarySmallLoading", | ||
| ).forEach { | ||
| composeTestRule.onNodeWithTag(it).assertHeightIsEqualTo(40.dp) | ||
| } | ||
| composeTestRule.onNodeWithTag("PrimaryLarge").assertHeightIsEqualTo(56.dp) | ||
| composeTestRule.onNodeWithTag("SecondaryLarge").assertHeightIsEqualTo(56.dp) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.