Skip to content

ci: use dedicated staging e2e greps - #1283

Merged
jvsena42 merged 1 commit into
masterfrom
e2e/transfer-1-staging
Sep 17, 2026
Merged

jvsena42 merged 1 commit into
masterfrom
e2e/transfer-1-staging

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

This PR points the nightly staging E2E matrix at dedicated staging greps, including transfer via @transfer_staging.

Companions: synonymdev/bitkit-ios#762 and synonymdev/bitkit-e2e-tests#226 (same branch e2e/transfer-1-staging).

Staging dispatch (in progress, post_to_slack=false): https://github.com/synonymdev/bitkit-android/actions/runs/35149237573

Description

  • Replaces the staging E2E shards so multi_address, pubky_paykit, and transfer grep @*_staging tags from the matching bitkit-e2e-tests branch.
  • Keeps the hardware_wallet shard on @hardware_wallet (not _staging) so Android stays aligned with iOS local HW runs.
  • Leaves schedule, workflow_dispatch, Slack, concurrency, and the Trezor image pull condition unchanged; the hardware shard name is the same.

Out of Scope

  • .github/workflows/e2e.yml: PR merge-gate staging shards stay on the current local/regtest greps.
  • bitkit-e2e-tests: harness tags land on e2e/transfer-1-staging in that repo, not here.
  • Reviewers: not requested yet.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Manual Tests

N/A

Automated Checks

  • No unit-test coverage changed. BuildOutputContractTest.kt already lists e2e-staging.yml in ARTIFACT_CONSUMERS and does not assert shard names.
  • Workflow YAML only. After merge: nightly/dispatch e2e-staging.yml should run multi_address / pubky_paykit / transfer against @*_staging and hardware_wallet against @hardware_wallet.
  • Staging dispatch on this branch: https://github.com/synonymdev/bitkit-android/actions/runs/35149237573
Open in Web Open in Cursor 

Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
@piotr-iohk
piotr-iohk marked this pull request as ready for review September 17, 2026 08:16
@github-actions

Copy link
Copy Markdown
Contributor

Regtest APK

Built from b12225a (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The workflow-only change appears safe to merge, with no concrete functional or repository-rule violations identified.

Summary

Updates the nightly staging E2E matrix to select dedicated staging test groups.

  • Uses staging-specific greps for multi-address, Pubky/Paykit, and transfer tests.
  • Renames the corresponding multi-address and transfer shards.
  • Leaves the hardware-wallet shard and its grep unchanged.

Reviews (1) · Last reviewed commit: "ci: use dedicated staging greps in e2e m..."

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve


Review: diff 1 file.
Counterpart synonymdev/bitkit-ios#762: equivalent.

Findings:
N/A

Audit:
Skipped - no security surface in the diff (score 0, threshold 3).


Reviewed by grok-4.6-xhigh via gh-pr-review-loop skill
Commands: @ovi-reviewer test · retest · audit (author or owner)

@jvsena42
jvsena42 merged commit a17f662 into master Sep 17, 2026
58 of 60 checks passed
@jvsena42
jvsena42 deleted the e2e/transfer-1-staging branch September 17, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants