ci: use dedicated staging e2e greps - #1283
Merged
Merged
Conversation
Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
piotr-iohk
marked this pull request as ready for review
September 17, 2026 08:16
Contributor
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
|
There was a problem hiding this comment.
Verdict: ✅ Approve
Review: diff 1 file.
Counterpart synonymdev/bitkit-ios#762: equivalent.
Findings:
N/A
Audit:
Skipped - no security surface in the diff (score 0, threshold 3).
Reviewed by grok-4.6-xhigh via gh-pr-review-loop skill
Commands: @ovi-reviewer test · retest · audit (author or owner)
jvsena42
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR points the nightly staging E2E matrix at dedicated staging greps, including transfer via
@transfer_staging.Companions: synonymdev/bitkit-ios#762 and synonymdev/bitkit-e2e-tests#226 (same branch
e2e/transfer-1-staging).Staging dispatch (in progress,
post_to_slack=false): https://github.com/synonymdev/bitkit-android/actions/runs/35149237573Description
multi_address,pubky_paykit, andtransfergrep@*_stagingtags from the matchingbitkit-e2e-testsbranch.hardware_walletshard on@hardware_wallet(not_staging) so Android stays aligned with iOS local HW runs.Out of Scope
.github/workflows/e2e.yml: PR merge-gate staging shards stay on the current local/regtest greps.bitkit-e2e-tests: harness tags land one2e/transfer-1-stagingin that repo, not here.Design
N/A — no UI changes.
Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
BuildOutputContractTest.ktalready listse2e-staging.ymlinARTIFACT_CONSUMERSand does not assert shard names.e2e-staging.ymlshould runmulti_address/pubky_paykit/transferagainst@*_stagingandhardware_walletagainst@hardware_wallet.