Skip to content

ci: use dedicated staging e2e greps - #762

Merged
jvsena42 merged 1 commit into
masterfrom
e2e/transfer-1-staging
Sep 17, 2026
Merged

jvsena42 merged 1 commit into
masterfrom
e2e/transfer-1-staging

Conversation

@piotr-iohk

Copy link
Copy Markdown
Collaborator

This PR updates the iOS staging E2E matrix to dedicated staging greps, including a transfer shard that runs @transfer_1 and @transfer_max via @transfer_staging.

Description

  • Replaces the multi_address_2, pubky, and transfer_max shards with multi_address (@multi_address_staging), pubky (@pubky_staging), and transfer (@transfer_staging) so staging matches the new harness tags.
  • Leaves schedule, workflow_dispatch, Slack summary, and concurrency unchanged.

Out of Scope

  • .github/workflows/e2e-staging.yml: no hardware_wallet shard on iOS staging; hardware remains local on iOS.
  • .github/workflows/e2e-tests.yml: local merge-gate greps stay as they are.
  • Harness tag definitions live on synonymdev/bitkit-e2e-tests branch e2e/transfer-1-staging.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Manual Tests

N/A

Automated Checks

  • Workflow YAML only. After this PR is open, gh workflow run e2e-staging.yml --ref e2e/transfer-1-staging -f e2e_branch=e2e/transfer-1-staging -f post_to_slack=false (after merge: the same dispatch on master) should resolve to the matching harness branch and run the three new shards.
Open in Web Open in Cursor 

Replace the multi_address_2, pubky, and transfer_max shards with
dedicated @*_staging greps, including a transfer shard that covers
@transfer_1 and @transfer_max via @transfer_staging.

Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
@piotr-iohk
piotr-iohk marked this pull request as ready for review September 17, 2026 08:16
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The workflow-only change appears safe to merge, with no concrete correctness, security, or repository-rule issues identified.

Summary

Updates the iOS staging E2E matrix to use dedicated staging selectors.

  • Replaces the multi-address selector with @multi_address_staging.
  • Replaces the Pubky selector with @pubky_staging.
  • Consolidates staging transfer coverage under @transfer_staging.
  • Renames the corresponding matrix shards while leaving workflow control flow unchanged.

Reviews (1) · Last reviewed commit: "ci: use dedicated staging e2e greps"

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve


Review: diff 1 file.
Counterpart synonymdev/bitkit-android#1283: equivalent.

Findings:
N/A

Audit:
Skipped - no security surface in the diff (score 0, threshold 3).


Reviewed by grok-4.6-xhigh via gh-pr-review-loop skill
Commands: @ovi-reviewer test · retest · audit (author or owner)

@jvsena42
jvsena42 merged commit 4e870e2 into master Sep 17, 2026
87 of 97 checks passed
@jvsena42
jvsena42 deleted the e2e/transfer-1-staging branch September 17, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants