fix: best-effort dismiss of Background Payments intro sheet - #236
Merged
Merged
Conversation
3 tasks
Hard-waiting on BackgroundPaymentsIntro-later flakes the Android send shard when the timed sheet is already gone or auto-dismissed. Poll like waitForToastBestEffort and still dismiss Later/Cancel when the intro is shown. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/845-node-start-cancellation
branch
from
September 18, 2026 16:45
0fac8a5 to
fe1e0fc
Compare
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 9b95a97)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Rebased onto latest
mainafter #233 and #235. Same unique helper as #234 / #241: best-effortdismissBackgroundPaymentsTimedSheetso a missing Background Payments intro does not fail the Android send shard.Companion app branch:
fix/845-node-start-cancellation(bitkit-android#1291).Why
Android merge-gate E2E failed only on
e2e-tests-local - sendfor synonymdev/bitkit-android#1291 (reconcile node state on start cancel):https://github.com/synonymdev/bitkit-android/actions/runs/35350904166
Error 3/3:
element BackgroundPaymentsIntro-later still not displayed after 30000msindismissBackgroundPaymentsTimedSheet, called fromsend.e2e.ts@send_2. Product changes are unrelated. Same-named harness branch sodetermine-e2e-branchpicks this up.Change
Soften
dismissBackgroundPaymentsTimedSheetto awaitForToastBestEffort-style poll:triggerTimedSheetUnlessPresentso we do not HeaderMenu-trigger over an already-visible sheet.Conflict resolution: kept this PR’s best-effort poll; dropped
main’s leftover #235 hard-wait body. Settings toast soft-wait is already onmain(#233) and was not part of this PR.Test plan
eslint+tsc --noEmitontest/helpers/actions.tse2e-tests-local - sendon android#1291 after this rebase (no emulator in this environment)