Skip to content

test: match boost_2 RBF activity list (behavior change) - #241

Closed
piotr-iohk wants to merge 3 commits into
mainfrom
fix/896-spread-pasted-seed-words
Closed

piotr-iohk wants to merge 3 commits into
mainfrom
fix/896-spread-pasted-seed-words

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

TL;DR

BEHAVIOR CHANGE — do not auto-merge. Needs Piotr review.

@boost_2 now expects the post-RBF home activity list shown on Android: three short rows, no BoostingIcon. The earlier Background Payments intro soft-dismiss fix stays on this branch.

Why

Android product PR synonymdev/bitkit-android#1296 (fix/896-spread-pasted-seed-words, seed paste — unrelated to this fail) failed 3/3 on local @boost_2:

https://github.com/synonymdev/bitkit-android/actions/runs/35523204562

Job: e2e-tests-local - onchain_boost_receive_widgets

Error: element ("android=new UiSelector().resourceId(\"BoostingIcon\")") still not displayed after 30000ms after BoostSuccessToast.

Failure screenshots (attempt 1 and 3, same UI) show three home activity rows and no boosting icon:

  1. Sent — "Confirms in ±Xm" — pending replacement (-10 422)
  2. Sent — "Removed from Mempool" — original replaced (-10 422)
  3. Received — time — +100 000

This is a product/behavior harness update for the RBF activity list, not a flake/timing fix. Same pattern was seen on android#1290 (2026-09-18). E2E_BRANCH already resolves to this branch.

Change

@boost_2 in test/specs/boost.e2e.ts only (@boost_1 CPFP untouched):

  • Stop requiring BoostingIcon on the list after BoostSuccessToast (testID still exists in the app for CPFP / isBoosting(), but it is not rendered on this RBF list).
  • Expect three short rows: pending Sent ("Confirms in"), Removed from Mempool Sent, Received +100 000.
  • Open ActivityShort-0 for the replacement: amount 10 000, fee increased, new txid. Assert visible "Confirming" instead of BoostedButton / StatusBoosting / RBFBoosted (those tags depend on isBoosted, which the list UI shows is false).
  • Open ActivityShort-1 and assert StatusRemoved / "Removed from Mempool".
  • After wipe-restore, re-check the same three-row list + confirming replacement. After mine, ActivityShort-0 is still StatusConfirmed.

Also on this branch (keep)

Best-effort dismiss of the Background Payments intro sheet (dismissBackgroundPaymentsTimedSheet), port of #234. That remains so ephemeral intro sheets do not fail send coverage.

Test plan

  • eslint + tsc --noEmit on test/specs/boost.e2e.ts
  • Re-run Android e2e-tests-local - onchain_boost_receive_widgets on android#1296 after this lands (no emulator in this environment)
  • Piotr review before merge — RBF activity semantics / row order
Open in Web Open in Cursor 

Soften dismissBackgroundPaymentsTimedSheet to a waitForToastBestEffort-style
poll so ephemeral intro sheets that already auto-dismissed do not fail send
coverage. Matches the same harness change as #234.

Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
jvsena42 and others added 2 commits September 18, 2026 15:46
After a successful RBF boost the home list keeps the pending
replacement (Sent / Confirms in) and the original send
(Removed from Mempool) plus the receive. Stop requiring
BoostingIcon / BoostedButton / StatusBoosting on that path.

Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
@cursor cursor Bot changed the title fix: best-effort dismiss of Background Payments intro sheet test: match boost_2 RBF activity list (behavior change) Sep 21, 2026
@piotr-iohk

Copy link
Copy Markdown
Collaborator Author

Closing: this is not an intended RBF behavior change.

@boost_2 on main is still the right assertion (pending boosted send + BoostingIcon, original hidden). The three-row list with no boosting icon is a race: RBF broadcasts, the replace handler writes isBoosted/boostTxIds, then a concurrent payment sync overwrites the replacement as a plain send so the original stays visible as "Removed from Mempool".

That flake shows up on master and on android#1296 (seed paste, unrelated). It is not a product update and should not be papered over in e2e.

The Background Payments dismiss from this branch is already on main (fe1e0fc). Remote branch fix/896-spread-pasted-seed-words is being deleted so android#1296 CI does not keep resolving to these wrong assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants