Feat/nav3 #81
Feat/nav3 #81
Conversation
- settings_04: add second swipe to dismiss receive sheet fully - settings_07: add tap on BackupIntroViewContinue before seed display 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Increased distance from 60% to 80% of screen (10%→90%) - Reduced move duration from 200ms to 100ms - Removed 50ms pause before move - Reverted double-swipe workaround in settings_04 The app's SheetHost.kt requires higher velocity (2500 px/sec) to dismiss sheets to prevent accidental dismissals during scrolling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
| startY = height * 0.2; | ||
| endY = height * 0.8; | ||
| startY = height * 0.1; | ||
| endY = height * 0.9; |
There was a problem hiding this comment.
why exactly this is introduced?
| { type: 'pointerDown', button: 0 }, | ||
| { type: 'pause', duration: 50 }, | ||
| { type: 'pointerMove', duration: 200, x: endX, y: endY }, | ||
| { type: 'pointerMove', duration: 100, x: endX, y: endY }, |
There was a problem hiding this comment.
👎
The param values are tailored to work reliably on both platforms. I think it may cause flakiness.
| 'appium:deviceName': 'Pixel_6', | ||
| 'appium:platformVersion': '13.0', | ||
| 'appium:deviceName': process.env.DEVICE_NAME || 'Pixel_6', | ||
| 'appium:platformVersion': process.env.PLATFORM_VERSION || '15', |
There was a problem hiding this comment.
this is unrelated change to the android Feat/nav3, why introducing this? It breaks current CI flow.
| services: [ | ||
| [ | ||
| 'appium', | ||
| { | ||
| args: { | ||
| port: 4723, | ||
| }, | ||
| command: 'appium', | ||
| }, | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Unrelated to original change. Should not be introduced there.
| await tap('BackupIntroViewContinue'); // proceed past backup intro screen | ||
| await sleep(1000); |
There was a problem hiding this comment.
I think this is actually a bug I point out here: synonymdev/bitkit-android#554 (comment)
Tests should remain unchanged.
test/specs/settings.e2e.ts
Outdated
| (await elementByText(tag)).waitForDisplayed(); | ||
| await swipeFullScreen('down'); | ||
| await sleep(500); | ||
| await swipeFullScreen('down'); // second swipe to dismiss receive sheet |
There was a problem hiding this comment.
I believe this was to cover a bug I point out here: synonymdev/bitkit-android#554 (comment) (the second one)
Test should remain unchanged. Note that adding such changes would surely break the flow on iOS.
No description provided.