Skip to content

Feat/nav3 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piotr-iohk wants to merge 4 commits into from
+18 −7
Closed

Feat/nav3 #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c4d561
fix: make platform version configurable for local testing
ovitrif Dec 27, 2025
6406751
fix: update settings tests for Nav3 navigation changes
ovitrif Dec 27, 2025
0341a95
fix: configure appium service to use port 4723
ovitrif Dec 28, 2025
b949d45
fix: make swipeFullScreen faster to dismiss sheets properly
ovitrif Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/helpers/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,8 @@ export async function swipeFullScreen(direction: Direction) {
endY = height * 0.2;
break;
case 'down':
startY = height * 0.2;
endY = height * 0.8;
startY = height * 0.1;
endY = height * 0.9;
Copy link
Collaborator Author

@piotr-iohk piotr-iohk Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why exactly this is introduced?

break;
}

Expand All @@ -347,8 +347,7 @@ export async function swipeFullScreen(direction: Direction) {
actions: [
{ type: 'pointerMove', duration: 0, x: startX, y: startY },
{ type: 'pointerDown', button: 0 },
{ type: 'pause', duration: 50 },
{ type: 'pointerMove', duration: 200, x: endX, y: endY },
{ type: 'pointerMove', duration: 100, x: endX, y: endY },
Copy link
Collaborator Author

@piotr-iohk piotr-iohk Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎
The param values are tailored to work reliably on both platforms. I think it may cause flakiness.

{ type: 'pointerUp', button: 0 },
],
},
Expand Down
2 changes: 2 additions & 0 deletions test/specs/settings.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ describe('@settings - Settings', () => {
await sleep(1000);
await tap('BackupWallet');
await sleep(1000); // animation
await tap('BackupIntroViewContinue'); // proceed past backup intro screen
await sleep(1000);
Comment on lines +275 to +276
Copy link
Collaborator Author

@piotr-iohk piotr-iohk Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is actually a bug I point out here: synonymdev/bitkit-android#554 (comment)

Tests should remain unchanged.


// get the seed from SeedContainer
const seedElement = await elementById('SeedContainer');
Expand Down
16 changes: 13 additions & 3 deletions wdio.conf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ export const config: WebdriverIO.Config = {
? {
platformName: 'Android',
'appium:automationName': 'UiAutomator2',
'appium:deviceName': 'Pixel_6',
'appium:platformVersion': '13.0',
'appium:deviceName': process.env.DEVICE_NAME || 'Pixel_6',
'appium:platformVersion': process.env.PLATFORM_VERSION || '15',
Copy link
Collaborator Author

@piotr-iohk piotr-iohk Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unrelated change to the android Feat/nav3, why introducing this? It breaks current CI flow.

'appium:app': path.join(__dirname, 'aut', 'bitkit_e2e.apk'),
// 'appium:app': path.join(__dirname, 'aut', 'bitkit_v1.1.2.apk'),
'appium:autoGrantPermissions': true,
Expand Down Expand Up @@ -136,7 +136,17 @@ export const config: WebdriverIO.Config = {
// Services take over a specific job you don't want to take care of. They enhance
// your test setup with almost no effort. Unlike plugins, they don't add new
// commands. Instead, they hook themselves up into the test process.
services: ['appium'],
services: [
[
'appium',
{
args: {
port: 4723,
},
command: 'appium',
},
],
],
Comment on lines +139 to +149
Copy link
Collaborator Author

@piotr-iohk piotr-iohk Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to original change. Should not be introduced there.


// Framework you want to run your specs with.
// The following are supported: Mocha, Jasmine, and Cucumber
Expand Down