chore: use journeys as prs qa contract

[ovitrif]

Closes #742

Counterpart: synonymdev/bitkit-android#1250

Description

• Makes #### Journeys the first QA Notes section so that a PR with a user-visible change lists the journeys that prove it, by bare file name with new or updated, and reviewers drive them on a device instead of reading prose.
• Limits #### Manual Tests to steps that need a capability the journey environment lacks, and adds a ## Capabilities table to journeys/README.md as the authority for what it provides, so a step is manual by evidence, not by category.
• Shapes #### Automated Checks as a flat list with added, updated, removed, and ran keywords so the same prefix is never repeated.
• Applies the rules in /pr and states them in AGENTS.md, and lists the xcodebuildmcp CLI under Prerequisites because it is how an agent drives the simulator through journeys.

Out of Scope

• journeys/: drift tooling, an identifier index, or a CI check; a journey that fails at review is the drift signal.
• A shared journeys skill giving iOS and Android one driving procedure; each platform names its own driver.
• Past manual tests from merged PRs: kept as a backlog in chore: keep past manual tests as a journeys backlog #763.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

• ran a per-file diff of the added lines against the counterpart PR: only platform names, test-file types, the driver, and Capabilities rows differ
• ran a diff of the ### QA Notes template section against the counterpart: identical apart from the example test-file name
• ran the review skill's parser tests against the new #### Journeys and #### Automated Checks formats: bare names resolve on the PR head, legacy full paths still parse
• ran every Capabilities row back to the suite README or preconditions section it cites

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with a non-blocking issue in /pr journey discovery that can generate misleading QA entries.

Findings

1.  Non-journey files get listed ▶

Summary

This PR makes journeys the primary QA contract for user-visible changes and standardizes how PR authors describe journey coverage, exceptional manual testing, and automated checks.

• Adds the Journeys section and structured QA guidance to the PR template and /pr command.
• Documents xcodebuildmcp as required tooling for driving journeys.
• Defines the capabilities available to journey authors and reviewers.
• One command currently includes non-XML support files in the journey list.

_{Reviews (2) · Last reviewed commit: "docs: list journey capabilities in readm..."}

[jvsena42]

One MEDIUM and one LOW (inline). Both are docs-only, so they don't block. The MEDIUM is shared with the Android twin, synonymdev/bitkit-android#1250.

Checked and clean:

• The added pr.md and template lines match Android apart from test-file naming and the View/Screen suffix.
• The AGENTS.md QA-contract bullet matches Android.
• The "not a QA gate" wording and the #suites anchor are removed with no dangling references.
• Capability link targets exist.
• The to.bitkit bundle id in the simctl uninstall row matches pbxproj.
• The missing UTXO and deep-link-router rows are platform-forced.
• \.xml$ discovery filter present.

[jvsena42]

A user-visible change that no journey can drive has no valid #### Journeys value.

Line 147 tells /pr to stop when a user-visible change has no covering journey. The line above it makes N/A — no user-visible behaviour change. the only empty value. Line 188's style target lists a BLE pairing step under Manual Tests, and journeys/README.md says BLE/USB are not simulated. So a PR whose only user-visible change is in BLE pairing or the USB permission flow either halts here or gets the false N/A — no user-visible behaviour change. next to a manual test. The template's #### Journeys comment at .github/pull_request_template.md:25 has the same gap.

Fix: allow an explicit value for this case, e.g. N/A — not drivable; see Manual Tests., in both pr.md and the template. Mirror it on the Android twin.

[jvsena42]

LOW: the Capabilities table has no row for two linked Bitkit wallets, though journeys/subscriptions/*.xml ships on iOS.

Android has the row ("Two linked Bitkit wallets for a subscription lifecycle"). Here the requirement only appears in prose under Not ported (:160-162). pr.md:148 sends any step needing a capability not in this table to Manual Tests. An iOS subscription PR that follows it literally files the two-wallet steps as manual instead of updating review-and-subscribe.xml, and its QA section diverges from the Android twin's.

Fix: port the Android row, linking subscriptions/ or #not-ported.