Refactored Check-in - #336
Open
Jackcuii wants to merge 50 commits into
Open
Conversation
- Add CgraRTL_relu4x4_test_from_yaml.py: ReLU kernel test on 4x4 Mesh CGRA using relu.yaml compiled kernel config (II=5, 32 iterations) - Fix script_generator.py: swap STORE src_operands to match MemUnitRTL hardware expectation (in0=address, in1=data vs YAML order [data, addr])
…flag Bug #1 - CrossbarRTL all-or-nothing: Stale prologued data blocked entire crossbar - Mask recv_valid_vector, exclude prologued from send/recv_required_vector - Gate changed: recv_valid_or_prologue_allowing_vector Bug #2 - PhiRTL shared first flag: Multiple PHI_START on same tile failed - Detect iteration wrap via ctrl_addr, clear s.first only at boundaries - Added prev_ctrl_addr tracking Tests: ReLU 379 cycles (pass), SpMV 759 cycles (pass)
OPT_STR set waddr.val and wdata.val based only on input val signals without checking predicate. During pipeline drain cycles, data with predicate=0 but val=1 caused spurious stores that overwrote correct results (e.g., y[0]=30 overwritten by 0 in GEMV kernel). Gate waddr.val and wdata.val on both inputs' predicates, consistent with OPT_STR_CONST which already does this correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # fu/single/CompRTL.py # fu/single/test/CompRTL_test.py
# Conflicts: # mem/register_cluster/RegisterBankRTL.py
tancheng
reviewed
Sep 5, 2026
| recv_str = ",".join([str(x.msg) for x in s.recv_in]) | ||
| first_str = ",".join([str(x) for x in s.first]) | ||
| return f'[recv: {recv_str}] {opt_str} (const_reg: {s.recv_const.msg}) (first: {first_str})] = [out: {out_str}] (s.recv_opt.rdy: {s.recv_opt.rdy}, {OPT_SYMBOL_DICT[s.recv_opt.msg.operation]}, send[0].val: {s.send_out[0].val}) reached_vector_factor: {s.reached_vector_factor}; vector_factor_counter: {s.vector_factor_counter}; ctrl_addr_inport: {s.ctrl_addr_inport}' | ||
|
|
Owner
There was a problem hiding this comment.
We can have the newline at the end.
| kAttrVectorFactorPower = 'vector_factor_power' | ||
| kAttrIsLastCtrl = 'is_last_ctrl' | ||
| kAttrReadRegTowards = 'read_reg_towards' | ||
| kAttrReadRegRetain = 'read_reg_retain' |
tancheng
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.