Skip to content

feat!: run license-checker-rseidelsohn in check-licenses - #130

Merged
taraxvoid merged 3 commits into
mainfrom
chore/license-checker-rseidelsohn
Oct 12, 2026
Merged

taraxvoid merged 3 commits into
mainfrom
chore/license-checker-rseidelsohn

Conversation

@taraxvoid

Copy link
Copy Markdown
Owner

Settle on license-checker-rseidelsohn 5.x (final stable) instead of the
0.x @lizenz/checker. Its bin is license-checker-rseidelsohn, not
license-checker, so check-licenses now invokes that name.

BREAKING CHANGE: sites must replace their @lizenz/checker (or
license-checker) devDependency with license-checker-rseidelsohn.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

taraxvoid and others added 3 commits October 6, 2026 09:47
Settle on license-checker-rseidelsohn 5.x (final stable) instead of the
0.x @lizenz/checker. Its bin is `license-checker-rseidelsohn`, not
`license-checker`, so check-licenses now invokes that name.

BREAKING CHANGE: sites must replace their `@lizenz/checker` (or
`license-checker`) devDependency with `license-checker-rseidelsohn`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@taraxvoid
taraxvoid merged commit f84a0f6 into main Oct 12, 2026
2 checks passed
@taraxvoid
taraxvoid deleted the chore/license-checker-rseidelsohn branch October 12, 2026 04:31
taraxvoid added a commit that referenced this pull request Oct 12, 2026
…ckout (#141)

Why 0.12.2 never reached npm:

1. Run 38204136468 (push of #130, f84a0f6) was in flight when release PR
#137 merged (56239c2).
2. release-please reads the branch through the API, so that run created
v0.12.2 on 56239c2 and set `release_created=true`.
3. The publish job checked `git merge-base --is-ancestor v0.12.2 HEAD`,
but HEAD was the run's own checkout (f84a0f6), so it failed with "Tag
v0.12.2 is not on branch main".
4. #137's own run (38204156854) found v0.12.2 already released, so
`release_created` was false and publish was skipped.

Fix: compare the tag against `refs/remotes/origin/<branch>`, which the
job's `fetch-depth: 0` checkout fetches after release-please has
finished. This keeps the same guarantee (the tag is on this channel's
branch) and works no matter which push's run creates the release.

0.12.3 replaced 0.12.2 on npm, so I'm not republishing 0.12.2.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant