Skip to content

Add batching configuration options#267

Closed
w0l4i wants to merge 1 commit intotherealaleph:mainfrom
w0l4i:w0l4i-patch-1
Closed

Add batching configuration options#267
w0l4i wants to merge 1 commit intotherealaleph:mainfrom
w0l4i:w0l4i-patch-1

Conversation

@w0l4i
Copy link
Copy Markdown

@w0l4i w0l4i commented Apr 26, 2026

Added new configuration o## Overview
This PR addresses the performance bottlenecks identified in issue #263. As discussed, it moves hardcoded constants related to batching and timeouts into the configuration file.

Changes

  • Added batch_timeout_ms to config (default: 10000ms).
  • Added batch_coalesce_window_ms to config (default: 8ms).
  • Added max_batch_ops to config (default: 50).ptions for batching with defaults. ## Impact
    Users in high-latency environments (like GAS relays) can now tune these parameters to prevent long-tail blocking and improve tunnel responsiveness.

Added new configuration o## Overview
This PR addresses the performance bottlenecks identified in issue therealaleph#263. 
As discussed, it moves hardcoded constants related to batching and timeouts into the configuration file.

## Changes
- Added `batch_timeout_ms` to config (default: 10000ms).
- Added `batch_coalesce_window_ms` to config (default: 8ms).
- Added `max_batch_ops` to config (default: 50).ptions for batching with defaults.
## Impact
Users in high-latency environments (like GAS relays) can now tune these parameters to prevent long-tail blocking and improve tunnel responsiveness.
@therealaleph
Copy link
Copy Markdown
Owner

Closing in favour of #269 — same intent but #269 also wires the values through tunnel_client.rs (this PR adds the config fields without a consumer). Don't take this as a decline of the work — the field shape (batch_timeout_ms, batch_coalesce_window_ms, max_batch_ops with serde defaults) is the right call. See my comment on #269 for the next step.


[reply via Anthropic Claude | reviewed by @therealaleph]

@w0l4i
Copy link
Copy Markdown
Author

w0l4i commented Apr 26, 2026

i will wait for your turn , I'm sorry without good internet i can't run test build and this happened please do according to the plan by yourself #263

Closing in favour of #269 — same intent but #269 also wires the values through tunnel_client.rs (this PR adds the config fields without a consumer). Don't take this as a decline of the work — the field shape (batch_timeout_ms, batch_coalesce_window_ms, max_batch_ops with serde defaults) is the right call. See my comment on #269 for the next step.

[reply via Anthropic Claude | reviewed by @therealaleph]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants