Conversation
Added new configuration o## Overview This PR addresses the performance bottlenecks identified in issue therealaleph#263. As discussed, it moves hardcoded constants related to batching and timeouts into the configuration file. ## Changes - Added `batch_timeout_ms` to config (default: 10000ms). - Added `batch_coalesce_window_ms` to config (default: 8ms). - Added `max_batch_ops` to config (default: 50).ptions for batching with defaults. ## Impact Users in high-latency environments (like GAS relays) can now tune these parameters to prevent long-tail blocking and improve tunnel responsiveness.
Add batching configuration options
## Overview This PR addresses the performance bottlenecks identified in issue therealaleph#263. As discussed, it moves hardcoded constants related to batching and timeouts into the configuration file. ## Changes - Added `batch_timeout_ms` to config (default: 10000ms). - Added `batch_coalesce_window_ms` to config (default: 8ms). - Added `max_batch_ops` to config (default: 50). - Refactored `tunnel_client.rs` to use these configurable values instead of static constants. ## Impact Users in high-latency environments (like GAS relays) can now tune these parameters to prevent long-tail blocking and improve tunnel responsiveness.
|
Closing this iteration; the intent is correct but the patch doesn't compile yet. When I checked it out and ran `cargo build --release`, I got 7 errors: ``` What's blocking it:
This is a real architectural change, not a 15-line tweak. Two paths forward: A — I'll do Pass 1 myself. Take the field shape you proposed in #267 (which is right), plumb `Arc` down through `TunnelMux::start` → `mux_loop` → `fire_batch`, ship as v1.7.3. You stay credited as the design contributor. This unblocks Pass 2 (the per-deployment health tracking from #263) which has more design surface. B — You take another pass. With the three issues above resolved + a local `cargo build --release` verifying it compiles. I'll review the moment it's pushed. I'd take A — it's a few hours of work and the longer-tail Pass 2 is more interesting use of your time. But B is fine if you'd rather drive both. Let me know which. Either way, neither #267 nor this PR can land in their current shape. Closing as superseded; re-open with the fix or wait for v1.7.3 with my version. [reply via Anthropic Claude | reviewed by @therealaleph] |
i will wait for your turn , I'm sorry without good internet i can't run test build and this happened please do according to the plan by yourself #263 |
Overview
This PR addresses the performance bottlenecks identified in issue #263.
As discussed, it moves hardcoded constants related to batching and timeouts into the configuration file.
Changes
batch_timeout_msto config (default: 10000ms).batch_coalesce_window_msto config (default: 8ms).max_batch_opsto config (default: 50).tunnel_client.rsto use these configurable values instead of static constants.Impact
Users in high-latency environments (like GAS relays) can now tune these parameters to prevent long-tail blocking and improve tunnel responsiveness.