Persist shell navigation in sessionStorage when withRouter is off - #813
Merged
govindavashishtha merged 2 commits intoSep 21, 2026
Merged
Conversation
Hosts that opt out of URL routing keep place and per-route search state across reloads without the package mutating the browser URL; pasted share links still win on boot. Co-authored-by: Cursor <cursoragent@cursor.com>
govindavashishtha
requested review from
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 18, 2026 12:15
🦋 Changeset detectedLatest commit: 8eb3e8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
harshil-2096
approved these changes
Sep 21, 2026
govindavashishtha
deleted the
feat/shell-storage-routing-without-router
branch
September 21, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withRouteris false, shell places and per-route search params persist insessionStorage(tfy-aui-shell-location) via a sharedShellRouteSyncCore, without mutating the host URL.?view=sessions,?agentId=, …) still win on boot, then are stripped from the real URL so later reloads restore from storage.withRouter=trueURL behavior is unchanged; docs and a minor changeset cover the storage-mode semantics.Test plan
pnpm --filter @truefoundry/trueforge-ui test(or at leastShellStorageRouteSync,ShellRouteSync,LibrarySessionShareBoot,ShellModeContext,TrueForgeUItests)withRouter={false}: navigate settings / library agent tab / sessions / a session, reload — state restores; address bar stays clean?view=sessionsor?agentId=&sessionId=) into awithRouter={false}host — opens the right overlay, then strips query from the URLwithRouter(e.g. frontend): deep links, Back/Forward, and share query behavior still match previous URL routingMade with Cursor