Skip to content

fix(client): thread connection limits into the sync transport - #252

Merged
rkruze merged 2 commits into
nextfrom
roko/sync-pool-limits
Aug 4, 2026
Merged

fix(client): thread connection limits into the sync transport#252
rkruze merged 2 commits into
nextfrom
roko/sync-pool-limits

Conversation

@rkruze

@rkruze rkruze commented Aug 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@rkruze
rkruze requested a review from benesch August 3, 2026 23:10

@pushrax pushrax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this broke as of #111

there's some other httpx settings that aren't passed through, and might be worth doing, but we could wait for a use case (e.g. http1 vs http2 settings, cert verification settings)

@rkruze
rkruze merged commit 05dd0a2 into next Aug 4, 2026
8 checks passed
@stainless-app stainless-app Bot mentioned this pull request Aug 4, 2026
@benesch

benesch commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

there's some other httpx settings that aren't passed through, and might be worth doing, but we could wait for a use case (e.g. http1 vs http2 settings, cert verification settings)

I'll just do it now while it's on our minds: #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants