fix(client): thread all transport kwargs into the sync transport - #255
Merged
Conversation
Supplying a custom transport makes httpx ignore every transport construction kwarg, not just limits, so options like verify and http2 were silently dropped by the default sync client. Reproduce httpx's own transport construction so they take effect again.
pushrax
approved these changes
Aug 4, 2026
Member
|
could we just splat kwargs into it? |
Contributor
Author
Unfortunately not. The transport takes a small subset of the overall client args. |
Merged
stainless-app Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
Supplying a custom transport makes httpx ignore every transport construction kwarg, not just limits, so options like verify and http2 were silently dropped by the default sync client. Reproduce httpx's own transport construction so they take effect again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplying a custom transport makes httpx ignore every transport-construction kwarg, not just
limits. As a result the default sync client silently dropped options likeverifyandhttp2when a caller set them. This threads them through so they take effect again, matching httpx's own transport construction.Follow-up to #252, which fixed the same class of bug for
limitsonly.