Repository navigation
Windows host: compile the generated icon + VERSIONINFO resources - #15
Merged
Merged
Conversation
RIVET_WINDOWS_ICON_RC points at the resource script raco rivet build generates (app icon + version block), but this project never consumed it — the ResourceCompile group only existed in rivet's scaffold template, and this repo carries its own vcxproj. The exe shipped with no RT_GROUP_ICON and no RT_VERSION: the tray icon, taskbar button and Explorer listings all fell back to the generic application icon, and the tray entry the user sees was the white fallback box. With the group in place the exe carries the Fulcrum icon at resource ID 1 — the slot LoadIconW(MAKEINTRESOURCEW(1)) in MainWindow expects — and its VERSIONINFO block. Verified by enumerating the staged exe's resource directory: RT_ICON #1-#7, RT_GROUP_ICON #1, RT_VERSION #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exe shipped with no icon and no file identity. User-visible symptom: the tray entry — and any taskbar/Explorer listing — showed the generic fallback box instead of the Fulcrum logo.
Root cause (scaffold drift, not a rivet regression)
raco rivet buildgenerates.rivet/build/windows/app-icon.rc(app icon + VERSIONINFO) and pointsRIVET_WINDOWS_ICON_RCat it. Rivet's scaffold templateRivetHost.vcxprojconsumes it with aResourceCompilegroup — but this repo carries its ownRivetHost.vcxproj, which predates the feature and never got the group. Empirically the staged exe had zero RT_ICON / RT_GROUP_ICON / RT_VERSION resources.Fix
The same one-line group the template has:
Rivet-side companion: turinglambdaai/rivet#283 — the generated rc now emits the icon at numeric resource ID 1 (a bare
IDI_RIVET_APP_ICONidentifier compiles to a string-named resource thatLoadIconW(MAKEINTRESOURCEW(1))inMainWindowcan never reach). rivet issue #282 documents both halves and the follow-up idea of araco rivet doctorcheck for host projects that don't consume the variable.Verified on this machine
raco rivet build0 errors; full suite already green on main