Repository navigation
Make Windows package staging idempotent - #259
Merged
Merged
Conversation
turinglambdaai
force-pushed
the
issue-254-idempotent-staging
branch
from
October 16, 2026 00:07
3c07a4e to
4a68157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repeated package or release over a dirty
dist/tree could make the Windows copy path fail withcopy-file: destination exists; it could also retain files that disappeared from the new stage. The Windows package copier now recreates its destination before copying, matching the existing macOS and Linux behavior.The regression test packages twice into the same target, proves changed payloads are replaced, and proves stale files are removed.
Closes #254.
Validation:
PLTCOLLECTS="$PWD:" raco test rivet/tests/— 9,733 tests passed.