Repository navigation
Emit the Windows app icon at resource ID 1 - #283
Merged
Merged
Conversation
IDI_RIVET_APP_ICON compiled to a string-named resource: LoadIconW with MAKEINTRESOURCEW(1) — the app-icon slot hosts load for the tray and window — could never reach it. Numeric 1 is the conventional slot and deterministic; the resources test pins it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #282 (part 2).
IDI_RIVET_APP_ICON ICON "..."compiled to a string-named resource — an undefined bare identifier in .rc is a name, not an ID.LoadIconW(module, MAKEINTRESOURCEW(1)), the app-icon slot hosts load for the tray and the window, could never reach it, so hosts showing the embedded icon silently got the genericIDI_APPLICATIONfallback instead.The generated script now emits
1 ICON "..."— numeric, deterministic, the conventional slot (Explorer, shortcuts and installers all prefer the lowest-ID group icon, so packaging behavior is unchanged). The resources test pins the numeric form.Context: part 1 of #282 — downstream-owned vcxproj projects missing the
ResourceCompilegroup — is fixed on the fulcrum side (fulcrum fix branch); worth considering araco rivet doctorcheck that flags host projects which don't consumeRIVET_WINDOWS_ICON_RC.Verified on the Windows leg: fulcrum's staged exe now enumerates RT_ICON #1–#7, RT_GROUP_ICON #1, RT_VERSION #1, and the tray icon renders the real Fulcrum logo.