Skip to content

fix(macos): preserve newer quick-add drafts during asynchronous saves #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turinglambdaai merged 1 commit into from
Oct 21, 2026
Merged

fix(macos): preserve newer quick-add drafts during asynchronous saves #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions macos-host/Sources/RivetHost/AppModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ final class AppModel {
var expandedTaskID: Int64?
var searchText = ""
var quickAddText = ""
/// Prevent duplicate Enter/click submissions while an add is in flight.
private var quickAddInFlight = false
/// Live quick-add schedule preview (canonical parse via parse_due RPC).
var quickAddPreview: String?
/// Incremented by View menu → New Task; TaskPaneView focuses the
Expand Down Expand Up @@ -671,7 +673,7 @@ final class AppModel {
/// the backend `parse_due` RPC — one grammar on every platform
/// (pure-date intent clears the time).
func quickAdd(_ rawText: String) {
guard isConnected, let api else { return }
guard isConnected, let api, !quickAddInFlight else { return }
let trimmed = rawText.trimmingCharacters(in: .whitespaces)
guard !trimmed.isEmpty else { return }

Expand All @@ -685,7 +687,9 @@ final class AppModel {
return
}

quickAddInFlight = true
_Concurrency.Task {
defer { quickAddInFlight = false }
do {
// One quick-add grammar on every platform: the backend
// splits text + due (parse_quick_add), we just store it.
Expand All @@ -697,8 +701,12 @@ final class AppModel {
due_time: parsed.due_time,
notes: nil)
await MainActor.run {
quickAddText = ""
quickAddPreview = nil
// The user may have begun their next task while the old
// parse/save RPC was in flight. Never wipe a newer draft.
if quickAddText == rawText {
quickAddText = ""
quickAddPreview = nil
}
flashStatus(i18n.t("statusTaskAdded"))
reload()
}
Expand Down
Loading