Skip to content

fix(windows): make searched tasks editable and show their real list - #39

Merged
turinglambdaai merged 20 commits into
mainfrom
fix/windows-search-task-actions-and-list-identity
Oct 21, 2026
Merged

turinglambdaai merged 20 commits into
mainfrom
fix/windows-search-task-actions-and-list-identity

Conversation

@turinglambdaai

Copy link
Copy Markdown
Owner

User-facing bug

Windows search returns matches across all lists, even when a named list is selected. However, OnEditTask, SetTaskDueAsync and MoveTaskToListAsync only searched the currently loaded tasks_ list snapshot. A matching task belonging to another list appeared in search, but choosing Edit / reschedule / Move to List silently did nothing. Worse, MakeTaskRow hid the owning-list label whenever the sidebar was on a named list, so a global search result could misleadingly look as if it belonged to the selected list.

Changes

  • Resolve actionable tasks through the active global search_results_ first and the loaded snapshot second. This permits editing, rescheduling and moving tasks found by search even when outside the current view.
  • Always show the task's real list name + color dot on global search results, regardless of the selected sidebar view. This is crucial to distinguishing 工作 from 生活.
  • Refresh active search results after completion, rename, due-date updates, move or delete, so the visible results don't continue showing outdated task state.
  • Add a stable accessible ID on the search box and each search-result owner label; extend packaged Windows E2E to search for the task created under 生活 while that named list is active, then assert that the result explicitly identifies 生活.

Stacked dependencies

Built atop #36, itself atop #35 → #32. Merge in order #32 → #35 → #36 → this PR; verify combined diff and run integration checks after merges.

Acceptance

  • Windows host build and Product Acceptance green
  • While 生活 is selected, search finds both 工作 and 生活 tasks; each row displays the correct owning list
  • Search result outside the active list: Edit, Today/Tomorrow/Clear due, Move to List all work without silent no-op
  • Search result updates correctly after rename, move, delete and complete
  • Current-list task edits still work; verify light/dark and high DPI

Do not merge or publish until all gates are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant