feat: add confirmed collaboration planning - #35
Open
sddxl150-star wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
合并评估(monkeycode-ai 已本地验证:9 个单元测试通过、前端 Vite 构建通过、mergeable_state clean)
功能方向认可:隔离规划房 + 用户确认后才创建智能体,后端含并发锁、幂等处理和输入校验。但存在 2 个阻断性问题,修复后再合并:
1. CRLF 行尾符污染全文件(严重)
ai_engine.py、admin.py、ChatView.vue、style.css被从 LF 整体改成 CRLF,导致 9173 行 diff 中约 8900 行是行尾符假变化,真实逻辑改动仅约 257 行。git diff --check报大量 trailing whitespace。- 仓库无
.gitattributes,合并后会污染后续所有 diff、git blame 与 merge 冲突,且极易复发。 - 要求:以 LF 重新保存这些文件后提交,并补充
.gitattributes(如* text=auto)防止复发。
2. orchestrator 配置缺失,默认部署下功能不可用(严重)
POST /admin/collaboration/planning-room依赖 hub_settingorchestrator_agent_id,当前仓库无该设置的默认值、初始化逻辑或 UI 入口。- 默认部署下接口返回 400 "Default orchestrator is not configured",规划协作流程整体不可用。
- 要求:提供默认 orchestrator(自动创建或回退到已有系统智能体),或提供配置入口。
Contributor
|
本 PR 的修复版已通过 #37 合并到 master(LF 行尾 + orchestrator 兜底 + 测试可发现性修复)。建议关闭本 PR。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation