Skip to content

chore: retire pools after its move to Appwrite - #326

Merged
ChiragAgg5k merged 2 commits into
mainfrom
chore/retire-pools
Sep 23, 2026
Merged

ChiragAgg5k merged 2 commits into
mainfrom
chore/retire-pools

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

Pools now lives in Appwrite following appwrite/appwrite#13845. Remove packages/pools so this repository stops discovering and publishing it during Split runs. Refresh the local dependency graph, list pools with the packages maintained in Appwrite, and name it in the graph introduction alongside telemetry as an external requirement that is no longer drawn.

cache, client, messaging and queue retain their existing Packagist constraints on utopia-php/pools. The standalone mirror and release tags remain available.

Validation: bin/monorepo validate, vale README.md, and git diff --check pass.

Appwrite's post-merge Split run succeeded. The pools mirror head 74fddc5919b9ef451cd3d86029b496d5d199b10c is a fast-forward from the 2.1.2 tag and its tree f4de1b8c900c22a4e424b09e65247d3ced04e6ee exactly matches Appwrite's packages/pools. After merge, confirm this repository's Split no longer includes pools.

utopia-php/pools#30 (stale connection recovery) is still open on the mirror and needs an owner decision: re-open against packages/pools in appwrite/appwrite, or close.

Follow-up to appwrite/appwrite#13828.

utopia-php/pools now lives in appwrite/appwrite as packages/pools
(appwrite/appwrite#13845). Drop the package here so this repository
stops discovering and publishing it during Split runs, refresh the
dependency graph, and point readers at the new source location.
cache, client, messaging and queue keep their Packagist constraints
on utopia-php/pools; the mirror and release tags remain available.
@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the previous dependency-list conflation fixed and no new actionable failures introduced since the prior review.

Summary

This PR retires the local pools package after its move to Appwrite.

  • Removes the package’s source, tests, configuration, and mirror workflow from this monorepo.
  • Updates the generated local dependency graph so external utopia-php/pools requirements are no longer represented as local edges.
  • Documents Appwrite as the new source of truth while retaining Packagist dependency constraints in consuming packages.
  • Separates the documented telemetry and pools dependant lists, resolving the previous review finding.

Reviews (2) · Last reviewed commit: "docs: list telemetry and pools dependant..."

Comment thread README.md Outdated
@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff

These findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.

  • P1 Mirror redirect becomes stale packages/pools/.github/workflows/mirror.yml:15 ▶

    Deleting this workflow stops future Split updates before the copy already present in utopia-php/pools is changed. The mirror will keep invoking mirror-redirect.yml with package: pools, so new issues and pull requests are closed and contributors are sent to the deleted packages/pools path instead of the new Appwrite source. Publish a final mirror update that redirects contributors to Appwrite before excluding pools from Split.

client requires only pools and dns, http, schedule and storage only
telemetry, so one shared list overstated both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant