Skip to content

build!: upgrade Rust crate num-modular to v0.6.5 - #127

Open
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:GH126
Open

xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:GH126

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: remove the implicit num-bigint feature

Closes #126.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.11%. Comparing base (3f5db7d) to head (3d4b654).
⚠️ Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   78.64%   86.11%   +7.47%     
==========================================
  Files          13       16       +3     
  Lines        2585     3933    +1348     
  Branches      230      265      +35     
==========================================
+ Hits         2033     3387    +1354     
+ Misses        552      544       -8     
- Partials        0        2       +2     
Flag Coverage Δ
macos_latest 85.86% <ø> (+8.22%) ⬆️
ubuntu_latest 85.71% <ø> (+7.52%) ⬆️
windows_latest 15.40% <ø> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
❌ 1 regressed benchmark
✅ 18 untouched benchmarks
⏩ 9 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ three 39-bit primes (u128) 480.2 ms 1,352.9 ms -64.51%
⚡ num-prime (this crate) 8.7 s 2.1 s ×4.1
⚡ num-prime (this crate) 8.6 ms 5.5 ms +54.41%
⚡ num-prime (this crate) 5.8 ms 3.8 ms +52.65%
⚡ num-prime (this crate) 19.3 ms 12.9 ms +49.71%
⚡ a 35-bit prime to the 7th (246 bits) 630.9 µs 475.5 µs +32.7%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:GH126 (3d4b654) with main (866bc2c)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to num-modular v0.6.5

1 participant