Repository navigation
feat: true white-on-black OLED EPUB theme (refs #286) - #301
Merged
Merged
Conversation
Owner
|
Thanks @chortya, the implementation looks good and CI is passing. GitHub reports that the branch now conflicts with |
OLED black now renders pure #FFFFFF text and links on #000000 across the page, reader chrome, options sheet, overlays, dialogs, window background and status-bar strip. Selection inverts to white; ReadiumCSS night-mode blue links and pale-blue selection are overridden in-page. Images keep their original colours. Other reader themes and comics are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EpubOledWebViewInstrumentedTest checks the OLED link/selection script against the shipped ReadiumCSS night mode; EpubOledActivityInstrumentedTest checks the black window background and the installed page style, and that other themes do not get it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Material3 1.2's filled Card uses surfaceVariant, the grey hairline colour in the OLED scheme, so both playback panels rendered grey. They now take epubReaderOledPanelColors(): black with white content on OLED, the default card colours otherwise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chortya
force-pushed
the
up/feat-epub-oled-theme
branch
from
October 21, 2026 06:20
08c173f to
718d7ad
Compare
Contributor
Author
|
Thanks! Rebased onto current |
4 tasks done
van-geaux
approved these changes
Oct 21, 2026
van-geaux
left a comment
Owner
There was a problem hiding this comment.
Thanks @chortya, this is a well-scoped implementation with strong OLED coverage across the EPUB page, reader chrome, panels, dialogs, and activity window. The final head has been reviewed and the automated checks are passing. Approved.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution pause
The maintainer lifted the pause and invited split PRs in #286.
OLED blackEPUB reader theme becomes true white-on-black). Independent of the spread, typesetting and language PRs.Summary
OLED blackpreviously used off-white text (#F5F5F6), blue links and the regular dark app chrome, with grey surfaces around the black page. It now renders pure white on pure black end to end:Theme.BookOrbit.Reader.Oledapplied beforesuper.onCreate(black window and status-bar strip, black system dialogs viaoled_dialog_background). Switching into or out of OLED recreates the reader at the saved locator so the window theme matches.EpubReaderMaterialThemeswaps in a pure black/white Material scheme (no tonal tint) for the options sheet, chapter list, top/bottom bars, read-aloud and read-along panels. Chrome is opaque; edges and the current chapter use hairline outlines because shadows are invisible on black.Verification
./gradlew :app:testDebugUnitTest— 959/959 pass (newEpubOledThemeTest).:app:lintDebug— 0 errors.:app:assembleDebugsucceeds. No added trailing whitespace; line endings preserved.EpubOledActivityInstrumentedTest2/2 — black window background, OLED page style installed with white text/links on black; Dark theme does not get it.EpubOledWebViewInstrumentedTest1/1 — the OLED script against the shipped ReadiumCSS night mode (link blue → white, idempotent).EpubOledPanelsInstrumentedTest2/2 — read-aloud/read-along panel colours.EpubReaderThemeStoreInstrumentedTest1/1.ReadiumEpubOpenInstrumentedTest15/17,EpubReaderOptionsOverlayInstrumentedTest3/8,EpubMediaOverlayControlsInstrumentedTest3/4 — the same tests fail onmainon this emulator. One run ofReadiumEpubOpenInstrumentedTestwas cut short by a WebView renderer crash in the emulator; the affected test passed on rerun.CardusessurfaceVariant, so the read-aloud and read-along panels were grey on OLED. Fixed with explicit OLED card colours and a test; the re-review found no remaining issues.🤖 Generated with Claude Code