fix(settings): 字体选择器跟随系统文案,并按当前标签收缩宽度 - #565
Merged
Merged
Conversation
The closed font control showed the English catalog label even when the UI language was Chinese. Use settings.fontSystemDefault for the trigger and search, and size the pill to the current label like language and theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
设置 → 基础 → 外观 的字体选择器,收起时触发器显示的是字体目录里的英文
System default,界面语言为中文时也不会走已有的settings.fontSystemDefault。触发器还被固定成接近下拉菜单的宽度,不像语言 / 主题那样按当前标签收缩。改动
settings.fontSystemDefault,不再把fonts.ts里的英文目录标签露到 UI。width: max-content,上限为设置控件列),与语言、主题选择器一致。验证
node --test apps/desktop/test/settings-font-picker.test.mjs— 8/8未跑
verify:ui:*(本任务未要求)。未改链接打开目标。