[microfrontends] Guard local proxy error responses after headers sent#56
Open
plmrry wants to merge 2 commits into
Open
[microfrontends] Guard local proxy error responses after headers sent#56plmrry wants to merge 2 commits into
plmrry wants to merge 2 commits into
Conversation
… LocalProxy Signed-off-by: Paul Murray <paul.murray@vercel.com>
Signed-off-by: Paul Murray <paul.murray@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
plmrry
requested review from
kitfoster,
mknichel,
tim123abc and
tknickman
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The proxy will occasionally write to the
responseafter headers have already been written, causing:AI-Description (by Codex)
This PR guards the local proxy error handlers before writing a fallback 500 response.
The HTTPS production fallback path can receive an upstream request error after it has already forwarded response headers to the browser. In that state, calling
res.writeHead(500, ...)throwsERR_HTTP_HEADERS_SENTand crashes the proxy. The handler now returns when the response is already closed, and destroys the response when headers have already been committed.The same guard is also applied to the
http-proxyerror path, which had the same unguardedwriteHead(500)behavior.Validation: not run. This branch intentionally keeps the change minimal and only updates the response-state guards.